Sync telemetry should record `nserror` values which relate to networking as `httperror`s
Categories
(Firefox :: Sync, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: markh, Assigned: markh)
Details
Attachments
(1 file)
Looking into the new dashboards (which are fantastic), I thought I'd try and dig into some of the errors. tabs in particular is interesting as it relies so little that almost all errors tend to be related to sync itself (eg, there are no "database" errors etc involved).
The top 6 nserror errors for tabs are:
2147500036 == NS_ERROR_ABORT
2152398868 == NS_ERROR_NET_RESET
2152398878 == NS_ERROR_UNKNOWN_HOST
3253927937 == NS_ERROR_NOT_INITIALIZED
2152398862 == NS_ERROR_NET_TIMEOUT
2152398919 == NS_ERROR_NET_INTERRUPT
All of these other than NS_ERROR_ABORT and NS_ERROR_NOT_INITIALIZED have the "module" set to NS_ERROR_MODULE_NETWORK. So I propose we handle every error with this module as a httperror - that error already has a code attribute, but it's expected to be a http status error. I propose we just record the ensure nserror value - ie, just change the error name and leave the code behind.
Although NS_ERROR_ABORT doesn't have that module code, I propose we treat this as a special case anyway - I'm confident this error usually means some error establishing a network connection - and if we really cared about this in other contexts, we can still get at it - it's just a httperror instead of an nserror.
This would leave NS_ERROR_NOT_INITIALIZED, which I propose we leave alone for now until we get more context.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9417544f2f8f have sync telemetry report nserrors with NS_ERROR_MODULE_NETWORK as a httperror r=skhamis
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•