1769740 - Unnecessary Facebook banner is present when accepting the "Cookie Policy" at expertflyer.com with ETP set to STRICT

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect, P3)

Description

[Raul Bucata]

Attachment: Screenshot_33.png

Environment:
Operating system: Android 11/ Android 12
Firefox version: Firefox Nightly 102.0a1 (2015880747 -🦎102.0a1-20220513093538🦎)

Preconditions:
ETP set to STRICT
Clean profile

Steps to reproduce:

1. Navigate to: https://www.expertflyer.com/mobile/login.do.
2. Accept the "Cookie Policy" pop-up.
3. Observe the result.

Expected Behavior:
The login form loads as expected.

Actual Behavior:
The login form presents an unnecessary Facebook banner.

Notes:

• Not reproducible with ETP set to STANDARD.
• Works as expected using Chrome.
• Screenshot is attached.

Comment 1

[Thomas Wisniewski [:twisniewski]]

This looks like SmartBlock adding an extra, duplicate button when it doesn't have to (presumably because the site is using very old code which SmartBlock doesn't work properly with). I'll take a look at this ASAP.

Comment 2

[Thomas Wisniewski [:twisniewski]]

Based on FB's code, we just need to check if a given login button has any textContent before adding our own button, and if so, just leave it alone.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1769740 - have the SmartBlock Facebook SDK shim not provide a 'log in with Facebook' button if the placeholder has textContent already, to prevent multiple buttons from appearing; r?ksenia

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/774256e8b6a5
have the SmartBlock Facebook SDK shim not provide a 'log in with Facebook' button if the placeholder has textContent already, to prevent multiple buttons from appearing; r=ksenia,webcompat-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/774256e8b6a5

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:twisniewski, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Oana Arbuzov [:oanaarbuzov]]

I can confirm this is fixed, the page loads correctly now.
https://prnt.sc/lF3xxCJgYfWC

Tested with:
Browser / Version: Firefox Nightly 105.0a1 (🦎 105.0a1-20220816095503)
Operating System: Google Pixel 5 (Android 12) - 1080 x 2340 pixels, 19.5:9 ratio (~432 ppi density), Samsung Galaxy S8 (Android 9) - 1440 x 2960 pixels, 18.5:9 ratio (~570 ppi density)