1769848 - Improve ShadowRealm Syntax Error messages

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

When issuing a syntax error during ShadowRealm.prototype.evaluate, we should aspire to produce error messages of the same quality as eval.

Currently, all syntax errors are eaten, and a 'generic' "Syntax Error" message is emitted, due to the requirement that the error message be issued from the callee realm, not the ShadowRealm.

This should be rectifiable by copying relevant information out of the SyntaxError object.

Comment 1

[Nicolas B. Pierron [:nbp]]

If you add new error messages, make sure to document them on MDN, and to link them in the dev tools.
If you need any help for that, ping me on Matrix.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1769848 - Improve ShadowRealm Syntax Error messages through cloning r?jandem

By cloning the actual syntax error, we get the lovely usability of eval
error messages, but with the correct global.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dded94430704
Improve ShadowRealm Syntax Error messages through cloning r=jandem

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/dded94430704