1769849 - Consider reporting more information when ShadowRealm execution fails

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

When a wrapped function, or ShadowRealm.prototype.evauate throws, the ShadowRealm proposal wraps all failures in a new TypeError.

It would be nice to annotate that type error with more information, to help programmers work with ShadowRealms (as is, the developer experience is sort of dreadful, as all failures look identical)

We could inspect and copy out the .message and .name properties, though, only using pure operations to avoid potential side-effects inside the shadow realm (unless https://github.com/tc39/proposal-shadowrealm/issues/353 is resolved in such a way that side effects are allowed)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1769849 - Improve ShadowRealm.evaluate errors r?jandem

Conditionally attempt to extract .name and .message and use for issuing error.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1769849 - Improve errors from wrapped functions throwing r?jandem

Conditionally try to extract .name and .message and use in error message.

Depends on D151849

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8552d20058cf
Improve ShadowRealm.evaluate errors r=evilpie
https://hg.mozilla.org/integration/autoland/rev/262ce0dc4a1e
Improve errors from wrapped functions throwing r=jandem

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8552d20058cf
https://hg.mozilla.org/mozilla-central/rev/262ce0dc4a1e