176989 - string leak in nsHTMLDocument::StartDocumentLoad()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Harshal Pradhan]

nsHTMLDocument::StartDocumentLoad() appears to be leaking a string for some 
POST requests. This seems to have been introduced by the checkin for bug 162239.

Patch that fixes the leak is coming up (but it might be better to just cleanup 
the nsIMarkupDocumentViewer to return appropriate string class instead of a raw 
string)

Comment 1

[Harshal Pradhan]

Attachment: plug small string leak

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 104318 [details] [diff] [review]
plug small string leak

Please use nsXPIDLString and getter_Copies for requestCharset instead.

Comment 3

[Harshal Pradhan]

Attachment: use nsXPIDLString

Comment 4

[Boris Zbarsky [:bzbarsky]]

>     if (*requestCharset) {

Make that |if (!requestCharset.IsEmpty())| while you're here, ok?

Comment 5

[Harshal Pradhan]

Attachment: Doh! (fix late night braindamage)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 104347 [details] [diff] [review]
Doh! (fix late night braindamage)

sr=bzbarsky.

for the record, |if (*str)| _does_ work and even does the right thing for
nsXPIDLC?String, but it's just very non-idiomatic.  ;)

Comment 7

[Peter Van der Beken [:peterv]]

Comment on attachment 104347 [details] [diff] [review]
Doh! (fix late night braindamage)

r=peterv.

Comment 8

[Harshal Pradhan]

Can someone please check this in for me. jst? peterv? bz?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Done.  Sorry, I lost track of this one in my list of stuff to land....  Thanks
for the ping.