Closed Bug 1769907 Opened 2 years ago Closed 2 years ago

gv-junit test JavaScript Error: "TypeError: can't access property "menupopup", menulist is undefined"

Categories

(GeckoView :: General, defect, P3)

Unspecified
Android

Tracking

(firefox102 wontfix, firefox103 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
firefox102 --- wontfix
firefox103 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

When I run org.mozilla.geckoview.test.PromptDelegateTest gv-junit tests, I found the following JS error.

05-18 16:52:37.670 22608 22634 E GeckoConsole: [JavaScript Error: "TypeError: can't access property "menupopup", menulist is undefined" {file: "resource://gre/actors/SelectParent.jsm" line: 336}]
05-18 16:52:37.670 22608 22634 E GeckoConsole: hide@resource://gre/actors/SelectParent.jsm:336:7

I think that it is unnecessary to use Select(Parent|Child).jsm as actor by https://searchfox.org/mozilla-central/rev/8fe6930c0832009b3162bebee7d4ede1a4c8c9a8/toolkit/modules/ActorManagerParent.jsm#399-415 in GeckoView since we have another actor for GeckoViewPrompt.

Makoto, is the test passing, even though it has this JS error? Could this error cause problems for users on real websites?

Flags: needinfo?(m_kato)
Summary: JavaScript Error: "TypeError: can't access property "menupopup", menulist is undefined" → gv-junit test JavaScript Error: "TypeError: can't access property "menupopup", menulist is undefined"

(In reply to Chris Peterson [:cpeterson] from comment #1)

Makoto, is the test passing, even though it has this JS error? Could this error cause problems for users on real websites?

Test is succeeded and no effect by this error. So this is output only.

Flags: needinfo?(m_kato)

(In reply to Makoto Kato [:m_kato] from comment #2)

Test is succeeded and no effect by this error. So this is output only.

In that case, I'll make this bug priority P3. Nice to fix, but not a high priority unless it affects users or is invalidating the test's results.

Severity: -- → S4
Priority: -- → P3

Actually, GeckoView registers both desktop and mobile actor for <select>
element. It is unnecessary to use desktop's <select> actor.

But, if GeckoView doesn't register desktop's <select> actor,
layout/forms/test/test_select_reframe.html will be failure since GV doesn't
handle mozhidedropdown that is a event when the control is unbinded from
layout tree.

So we need to handle this for this situation that is one of dismissed cases.

Assignee: nobody → m_kato
Status: NEW → ASSIGNED
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/49cb7f47ea22
Don't register desktop's SelectChild and SelectParent in GeckoView. r=geckoview-reviewers,agi
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

The patch landed in nightly and beta is affected.
:m_kato, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox102 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(m_kato)
Flags: needinfo?(m_kato)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: