Closed Bug 1769972 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34108 - Turn off independent inheritance if children have explicitly inherited properties.

Categories

(Core :: CSS Transitions and Animations, task, P4)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34108 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34108
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Turn off independent inheritance if children have explicitly inherited properties.

If any of our children have explicit inheritance of a non-inherited
property, we cannot mark it as using independently inherited properties
only, as some of the explicit properties might inherit (our diffing
considers inherited properties only). We used to gate this behind
a test of diffs in the non-inherited properties, but that would only
consider that difference on this element, not its children (and the
problem could propagate fro there to its grandchildren).

This seems to have been broken in a refactor in
d7e0cc711958dfb3aa39f0f912db1f154617bd98.

Change-Id: If6b790fea727ad68322cde7c4c2a342322283f68

Reviewed-on: https://chromium-review.googlesource.com/3650513
WPT-Export-Revision: 648c267aaf91cf9eb7b1d2b8ee0aae3bd31e5b3b

Component: web-platform-tests → CSS Transitions and Animations
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4c9998dbf67 [wpt PR 34108] - Turn off independent inheritance if children have explicitly inherited properties., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.