176999 - JavaScript error generated by invoking Tool Menu items {error in cookieNavigatorOverlay.xul}

Status: VERIFIED WORKSFORME

(Core :: XUL, defect)

Description

[Jean-Pierre Melkonian]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:1.2b) Gecko/20021025
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:1.2b) Gecko/20021025

Error: element has no properties
Source File: chrome://cookie/content/cookieNavigatorOverlay.xul
Line: 128

Openning the Cookie Manager. I have this message 3 times, 5 times depends on ...
i don't know

I have also theese errors when the cookie manager is open and i choose "Tools->
Cookie Manager" in the menu

Reproducible: Always

Steps to Reproduce:
1. OPen Javascript console
2. Clear messages
3. OPen Cookie manager

Actual Results:  
Java script errors

Expected Results:  
No Errors

Comment 1

[Christopher Hoess (gone)]

The same error is reported in bug 137359.

Comment 2

[Jean-Pierre Melkonian]

Yes in bug 137359 Comment 6 And with my build. This is not the original reported 
message for that bug
Bug 137359 Comment 6 reports my message only for the Download Manager

Some more tests show that this message is generated with every item of the Tool 
Menu

So i think that it is not the same bug, and I change the description field to:
Javascript error using Tool Menu Items (Its a regression)

Comment 3

[Christopher Hoess (gone)]

*** Bug 177022 has been marked as a duplicate of this bug. ***

Comment 4

[Wesha]

I figured out that the function that causes the error message is called from the
following line in cookieNavigatorOverlay.xul: 

>  enableElement("BlockPopups", useManager && suitable && enableBlock);

obviously, something is wrong about "BlockPopups" stuff.

I can't figure out how to fix it, since I don't understand what it SHOULD do in
the first place.

Comment 5

[Greg K.]

Confirmed using FizzillaCFM/2002102508 on Mac OS X 10.1.5. Revising summary and
reassigning to XP Toolkit/Widgets.

Comment 6

[John Morrison]

This is due to the xul elements that were commented out of 
cookieNavigatorOverlay.xul in rev 1.10, while code that tries 
to access these elements is still being executed (henced getElementById
fails and returns a null object).

I'm assuming that the commenting-out is just a temporary measure.

Comment 7

[Andrew Schultz]

bug occurs with linux trunk build 20021026

Comment 8

[Henrik Gemal]

*** Bug 177243 has been marked as a duplicate of this bug. ***

Comment 9

[Daniel Veditz [:dveditz]]

Attachment: don't do what can't be done

Comment 10

[timeless]

Comment on attachment 104571 [details] [diff] [review]
don't do what can't be done

that'll work, there's a bit of js overhead for the function but we'll live.

Comment 11

[Daniel Veditz [:dveditz]]

I'll take this

Comment 12

[jag (Peter Annema)]

Comment on attachment 104571 [details] [diff] [review]
don't do what can't be done

sr=jag

Comment 13

[Stephen P. Morse]

*** Bug 178020 has been marked as a duplicate of this bug. ***

Comment 14

[John Morrison]

*** Bug 181376 has been marked as a duplicate of this bug. ***

Comment 15

[John Morrison]

Let's check this in.

Comment 16

[R.K.Aa.]

*** Bug 182390 has been marked as a duplicate of this bug. ***

Comment 17

[R.K.Aa.]

*** Bug 182530 has been marked as a duplicate of this bug. ***

Comment 18

[Olivier Cahagne]

*** Bug 184222 has been marked as a duplicate of this bug. ***

Comment 19

[Wesha]

With return of popup manager in 2002121008, this bug seems to no longer exist.
Marking WORKSFORME.

Comment 20

[Andrew Schultz]

*** Bug 185512 has been marked as a duplicate of this bug. ***

Comment 21

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401]

Confirming comment 19: WFM now.

Comment 22

[Wesha]

verified as per comment 21

Comment 23

[Jabez Gan]

It's fixed.