Closed Bug 1770025 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34116 - Return focus to previously-focused element on popup hide

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34116 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34116
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Return focus to previously-focused element on popup hide

Akin to \<dialog>'s behavior, the desired behavior is that focus
is returned to the previously-focused element when a popup is
hidden:

https://github.com/openui/open-ui/issues/327

Bug: 1307772
Change-Id: Ia6ae1981612a0c0150b8b5f51b485a00a9a90de9
Reviewed-on: https://chromium-review.googlesource.com/3627159
WPT-Export-Revision: 800274b1229a5b206ff263f59b82d5d94ac1034f

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 21 subtests

Status Summary

Firefox

OK : 1
PASS : 3
FAIL : 61
ERROR: 1

Chrome

OK : 2
PASS : 35
FAIL : 31

Safari

OK : 1
PASS : 3
FAIL : 61
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-focus.tentative.html [wpt.fyi]
    • Popup focus test: default behavior - popup is not focused: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: default behavior - popup is not focused: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup focus test: autofocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: autofocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: autofocus popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: autofocus empty popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: autofocus empty popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: autofocus empty popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: autofocus popup with button: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: autofocus popup with button: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: autofocus popup with button: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: autofocus child: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: autofocus child: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: autofocus child: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: autofocus on tabindex=0 element: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: autofocus on tabindex=0 element: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: autofocus on tabindex=0 element: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: autofocus multiple children: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: autofocus multiple children: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: autofocus multiple children: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: autofocus popup and multiple autofocus children: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: autofocus popup and multiple autofocus children: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: autofocus popup and multiple autofocus children: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: delegatesfocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: delegatesfocus popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: delegatesfocus popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: delegatesfocus takes precedence over autofocus: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: delegatesfocus takes precedence over autofocus: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: delegatesfocus takes precedence over autofocus: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: delegatesfocus takes precedence over autofocus 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: delegatesfocus takes precedence over autofocus 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: delegatesfocus takes precedence over autofocus 2: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: delegatesfocus on empty popup has no effect: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: delegatesfocus on empty popup has no effect: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup focus test: delegatesfocus on child has no effect: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: delegatesfocus on child has no effect: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup focus test: delegatesfocus skips contained popups: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: delegatesfocus skips contained popups: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: delegatesfocus skips contained popups: FAIL (Chrome: PASS, Safari: FAIL)
    • Popup focus test: delegatesfocus skips contained dialogs: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup button click focus test: delegatesfocus skips contained dialogs: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup corner cases test: delegatesfocus skips contained dialogs: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/popups/popup-light-dismiss.tentative.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • Clicking outside a popup will dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a popup does not close that popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus outside the popup will dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a child popup shouldn't close either popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking inside a parent popup should close child popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on invoking element, after using it for activation, shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on invoking element, even if it wasn't used for activation, shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on togglepopup element, even if it wasn't used for activation, should hide it exactly once: FAIL (Chrome: PASS, Safari: FAIL)
    • Clicking on anchor element (that isn't an invoking element) shouldn't close its popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Dragging from an open popup outside an open popup should leave the popup open: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element should be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • An invoking element that was not used to invoke the popup can still be part of the ancestor chain: FAIL (Chrome: PASS, Safari: FAIL)
    • Scrolling within a popup should not close the popup: FAIL (Chrome: FAIL, Safari: FAIL)
    • Moving focus back to the anchor element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to the active trigger element should not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Moving focus back to an inactive trigger element should also not dismiss the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional: FAIL (Chrome: PASS, Safari: FAIL)
    • Ensure circular/convoluted ancestral relationships are functional, with a direct showPopup(): FAIL (Chrome: PASS, Safari: FAIL)
    • Light dismiss of mixed popup types: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec66e3d03479 [wpt PR 34116] - Return focus to previously-focused element on popup hide, a=testonly https://hg.mozilla.org/integration/autoland/rev/98c7555cf0a8 [wpt PR 34116] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ec66e3d03479
https://hg.mozilla.org/mozilla-central/rev/98c7555cf0a8

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.