1770111 - GLContextProviderLinux.cpp:16:35: error: aggregate mozilla::gl::GLContextProviderGLX mozilla::gl::sGLContextProviderGGLX has incomplete type and cannot be defined

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Petr Sumbera]

Steps to reproduce:

Build on Solaris fails with:

13:16.29 /builds/psumbera/mozilla-central-build/gfx/gl/GLContextProviderLinux.cpp:16:35: error: aggregate mozilla::gl::GLContextProviderGLX mozilla::gl::sGLContextProviderGGLX has incomplete type and cannot be defined
13:16.29    16 | static class GLContextProviderGLX sGLContextProviderGLX;
13:16.29       |                                   ^~~~~~~~~~~~~~~~~~~~~
13:16.29 /builds/psumbera/mozilla-central-build/gfx/gl/GLContextProviderLinux.cpp:19:29: error: GLContextProviderLinux has not been declared
13:16.29    19 | already_AddRefed<GLContext> GLContextProviderLinux::CreateForCompositorWidget(
13:16.29       |                             ^~~~~~~~~~~~~~~~~~~~~~
13:16.29 /builds/psumbera/mozilla-central-build/gfx/gl/GLContextProviderLinux.cpp:32:29: error: GLContextProviderLinux has not been declared
13:16.29    32 | already_AddRefed<GLContext> GLContextProviderLinux::CreateHeadless(
13:16.29       |                             ^~~~~~~~~~~~~~~~~~~~~~
13:16.29 /builds/psumbera/mozilla-central-build/gfx/gl/GLContextProviderLinux.cpp:42:12: error: GLContextProviderLinux has not been declared
13:16.29    42 | GLContext* GLContextProviderLinux::GetGlobalContext() {
13:16.29       |            ^~~~~~~~~~~~~~~~~~~~~~
13:16.29 /builds/psumbera/mozilla-central-build/gfx/gl/GLContextProviderLinux.cpp:51:6: error: GLContextProviderLinux has not been declared

The first bad revision is:
changeset: 618109:0a64e06c72f0
user: stransky <[e-mail]>
date: Wed May 18 05:01:50 2022 -0700
description:
Bug 1769710 [Linux] Remove GLContextProviderX11 r=jgilbert

Differential Revision: https://phabricator.services.mozilla.com/D146548

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1769710

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1769710, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Please provide full build log. I need to know what's defined on Solaris.
Thanks.

Comment 5

[Petr Sumbera]

Attachment: build log

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1770111 [Linux] Build GLContextProviderLinux on other unix systems r?jgilbert

Comment 8

[Darkspirit]

Shouldn't it rather be MOZ_WIDGET_GTK?
XP_UNIX also includes Darwin:
https://wiki.mozilla.org/Platform/Platform-specific_build_defines
https://searchfox.org/mozilla-central/rev/7f729f601c0b738f870ae0ed49098f9268e250f9/js/src/builtin/TestingFunctions.cpp#37

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cde097a49a39
[Linux] Build GLContextProviderLinux on other unix systems r=jgilbert

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on GLContextProvider.h

Backout link

Push with failures

Failure log

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Darkspirit from comment #8)

Shouldn't it rather be MOZ_WIDGET_GTK?
XP_UNIX also includes Darwin:
https://wiki.mozilla.org/Platform/Platform-specific_build_defines
https://searchfox.org/mozilla-central/rev/7f729f601c0b738f870ae0ed49098f9268e250f9/js/src/builtin/TestingFunctions.cpp#37

Yes, that's correct, Thanks.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4c53c1ff842982f7a679123140abaa7c3f69e65

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27059949874a
[Linux] Build GLContextProviderLinux on other unix systems r=jgilbert

Comment 14

[Landry Breuil (:gaston)]

(In reply to Pulsebot from comment #13)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27059949874a
[Linux] Build GLContextProviderLinux on other unix systems r=jgilbert

fwiw this also fixes the m-c build issue i was seeing on OpenBSD, thanks !

Comment 15

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/27059949874a