1770133 - Make `IMEStateManager` store focused element instead of focused content node

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Only element node can have focus (see nsFocusManager::mFocusedElement). So, IMEStateManager::sContent should be IMEStateManager::sElement or more meaningful name, e.g., sFocusedElement?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770133 - part 1: Rename `sContent`, `sPresContext` and `sWidget` of `IMEStateManager` r=m_kato!

Depends on D147072

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770133 - part 2: Make `IMEStateManager::sFocusedContent` store it as `Element` r=m_kato!

nsFocusManager defines that focused content is at least dom::Element.
So IMEStateManager can handle focused content with dom::Element too.

Additionally, this patch makes IMEStateManager methods take references instead
of pointers as far as possible if they just return error for nullptr.

Depends on D147132

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770133 - part 3: Make `EditorBase::GetFocusedContent()` return `Element*` instead of `nsIContent*` r=m_kato!

Depends on D147133

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770133 - part 4: Make `IMEContentObserver` use `dom::Element` instead of `nsIContent` for root r=m_kato!

The root is always an element node. So, it should take and store the root node
as dom::Element rather than nsIContent.

Depends on D147134

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1770133 - part 5: Make `ContentEventHandler` store root node as `Element*` rather than `nsIContent*` r=m_kato!

Depends on D147135

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b92de4a984f1
part 1: Rename `sContent`, `sPresContext` and `sWidget` of `IMEStateManager` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/df84cc3d5d23
part 2: Make `IMEStateManager::sFocusedContent` store it as `Element` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/7322de6f865f
part 3: Make `EditorBase::GetFocusedContent()` return `Element*` instead of `nsIContent*` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6151c1cf0404
part 4: Make `IMEContentObserver` use `dom::Element` instead of `nsIContent` for root r=m_kato
https://hg.mozilla.org/integration/autoland/rev/8596922e3e2e
part 5: Make `ContentEventHandler` store root node as `Element*` rather than `nsIContent*` r=m_kato

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b92de4a984f1
https://hg.mozilla.org/mozilla-central/rev/df84cc3d5d23
https://hg.mozilla.org/mozilla-central/rev/7322de6f865f
https://hg.mozilla.org/mozilla-central/rev/6151c1cf0404
https://hg.mozilla.org/mozilla-central/rev/8596922e3e2e

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Backed out 5 changesets (bug 1770133) on beta, large refactoring during soft code freeze, needs nightly bake time a=backout
https://hg.mozilla.org/releases/mozilla-beta/rev/06fb57a24a5f