Closed Bug 1770152 Opened 4 months ago Closed 2 months ago

Enable perfstats for windows Browsertime essential tests

Categories

(Testing :: Raptor, task, P2)

task

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sparky, Assigned: myeongjun.ko, NeedInfo)

References

(Depends on 1 open bug, )

Details

Attachments

(2 files)

This bug is for enabling a subset of perfstats on windows for TP6 tests.

:denispal/:acreskey, how does this look for you?

Also, can you provide a set of perfstat metrics we should start with here?

Flags: needinfo?(dpalmeiro)
Flags: needinfo?(acreskey)

The current perfstats can be seen here.

We can include them all, but maybe starting with a minimal set would be easier (less data to look at).

DisplayListBuilding
HttpChannelCompletion_Network
HttpChannelCompletion_Cache

Or maybe we want them all and then we can see which are valuable.
Bas? Any thoughts

Flags: needinfo?(acreskey) → needinfo?(bas)

(In reply to Andrew Creskey [:acreskey] [he/him] from comment #2)

The current perfstats can be seen here.

We can include them all, but maybe starting with a minimal set would be easier (less data to look at).

DisplayListBuilding
HttpChannelCompletion_Network
HttpChannelCompletion_Cache

Or maybe we want them all and then we can see which are valuable.
Bas? Any thoughts

I would definitely also include Reflowing and Styling.

Flags: needinfo?(bas)

There's some ongoing work by Treeherder Ops to fix the signature limit! See bug 1343328.

I've set the bug as a dependency to this because if they can get this working for us, we'll be able to enable all perf stats everywhere. This doesn't change the fact that we need to eventually switch to a Time-Series Database such as InfluxDB over the long term to handle replicates but moving to one of those TSDBs to handle the signature issue will be a much lower priority.

Depends on: 1343328
Summary: Enable perfstats for Browsertime Windows TP6 tests → Enable perfstats for Browsertime tests

This patch enables the collection of perfstats through raptor-browsertime. It can be enabled by setting perfstats = true in the test manifest.

Assignee: nobody → gmierz2
Status: NEW → ASSIGNED
Keywords: leave-open

Treeherder ops (SRE) here! I'm not quite sure I have the full context on this but just to be explicit:
We're only performing a migration on the performance datum id column - not signature id. Signature id will still be an int.

Additionally, if you're planning any changes that may result in an increase in load on treeherder's database, can you let SRE know? #treeherder-ops on slack is a good go-to place. Treeherder has had recurring reliability issues - we do our best to keep it going, but the earlier we know about any upcoming changes, the better we can provide support.

Ah thanks for clarifying that Katie!

No longer depends on: 1343328
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/c08769c65208
Add option to collect perfstats in raptor-browsertime. r=perftest-reviewers,afinder
Summary: Enable perfstats for Browsertime tests → Enable perfstats for windows Browsertime essential tests
Assignee: gmierz2 → myeongjun.ko
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/1421754a7998
Enable perfstats for windows Browsertime essential tests r=sparky,perftest-reviewers
Depends on: 1780202

This is resolved now.

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
See Also: → 1780826
You need to log in before you can comment on or make changes to this bug.