1770157 - RefPtr<Foo> foo = std::move(rawPtrToFoo); leads a bug

Status: NEW

(Core :: MFBT, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

RefPtr and OwningNonNull have move constructors/operators to clear another strong pointer instance. However, if it's the argument is a raw pointer variable, it won't be cleared.

This is not unexpected behavior for C++ developers if and only if they are writing it and know that it's a raw pointer. So, in other words, if the source type is changed from a strong pointer to a raw pointer, such move constructors/operators become not used whether they are used.

Perhaps, if it's possible, move constructors/operators for raw pointer should be deleted (I don't know whether it's work). Or, std::move(T*) should be banned by the clang-plugin.