Closed Bug 1770167 Opened 2 years ago Closed 2 years ago

Perma [tier 2] tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand") [0.0 s]

Categories

(Core :: JavaScript Engine, defect, P5)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox100 --- unaffected
firefox101 --- unaffected
firefox102 --- fixed
firefox103 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: nbp)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered][stockwell unknown])

Attachments

(2 files)

Bug 1770167 - Skip delazification self-tests when code coverage is enabled.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1770167 - Self-test switch from CLI to evaluate options, to follow the test suite.
48 bytes, text/x-phabricator-request
Details | Review

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=378600331&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AaEWYAboR4K0xMQIZSJQZQ/runs/0/artifacts/public/logs/live_backing.log

[task 2022-05-19T11:19:20.675Z] 11:19:20     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\self-test\cacheEntry.js | Success (code 0, args "--baseline-eager") [0.2 s]
[task 2022-05-19T11:19:20.718Z] 11:19:20     INFO -  Exit code: 2147483651
[task 2022-05-19T11:19:20.718Z] 11:19:20     INFO -  FAIL - self-test\delazification-mode-00.js
[task 2022-05-19T11:19:20.718Z] 11:19:20  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand") [0.0 s]
[task 2022-05-19T11:19:20.718Z] 11:19:20     INFO -  INFO exit-status     : 2147483651
[task 2022-05-19T11:19:20.718Z] 11:19:20     INFO -  INFO timed-out       : False
[task 2022-05-19T11:19:20.742Z] 11:19:20     INFO -  Exit code: 2147483651
[task 2022-05-19T11:19:20.742Z] 11:19:20     INFO -  FAIL - self-test\delazification-mode-00.js
[task 2022-05-19T11:19:20.742Z] 11:19:20  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand --ion-eager --ion-offthread-compile=off --more-compartments") [0.0 s]
[task 2022-05-19T11:19:20.742Z] 11:19:20     INFO -  INFO exit-status     : 2147483651
[task 2022-05-19T11:19:20.742Z] 11:19:20     INFO -  INFO timed-out       : False
[task 2022-05-19T11:19:20.775Z] 11:19:20     INFO -  Exit code: 2147483651
[task 2022-05-19T11:19:20.775Z] 11:19:20     INFO -  FAIL - self-test\delazification-mode-00.js
[task 2022-05-19T11:19:20.775Z] 11:19:20  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand --ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.0 s]
[task 2022-05-19T11:19:20.775Z] 11:19:20     INFO -  INFO exit-status     : 2147483651
[task 2022-05-19T11:19:20.775Z] 11:19:20     INFO -  INFO timed-out       : False
[task 2022-05-19T11:19:20.790Z] 11:19:20     INFO -  TEST-PASS | tests\jit-test\jit-test\tests\self-test\cacheEntry.js | Success (code 0, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.2 s]
[task 2022-05-19T11:19:20.820Z] 11:19:20     INFO -  Exit code: 2147483651
[task 2022-05-19T11:19:20.820Z] 11:19:20     INFO -  FAIL - self-test\delazification-mode-00.js
[task 2022-05-19T11:19:20.820Z] 11:19:20  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand --baseline-eager") [0.0 s]
[task 2022-05-19T11:19:20.820Z] 11:19:20     INFO -  INFO exit-status     : 2147483651
[task 2022-05-19T11:19:20.821Z] 11:19:20     INFO -  INFO timed-out       : False
[task 2022-05-19T11:19:20.826Z] 11:19:20     INFO -  Exit code: 2147483651
[task 2022-05-19T11:19:20.826Z] 11:19:20     INFO -  FAIL - self-test\delazification-mode-00.js
[task 2022-05-19T11:19:20.826Z] 11:19:20  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand --no-blinterp --no-baseline --no-ion --more-compartments") [0.0 s]
[task 2022-05-19T11:19:20.826Z] 11:19:20     INFO -  INFO exit-status     : 2147483651
[task 2022-05-19T11:19:20.826Z] 11:19:20     INFO -  INFO timed-out       : False
[task 2022-05-19T11:19:20.848Z] 11:19:20     INFO -  Exit code: 2147483651
[task 2022-05-19T11:19:20.848Z] 11:19:20     INFO -  FAIL - self-test\delazification-mode-00.js
[task 2022-05-19T11:19:20.848Z] 11:19:20  WARNING -  TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand --blinterp-eager") [0.0 s]
[task 2022-05-19T11:19:20.848Z] 11:19:20     INFO -  INFO exit-status     : 2147483651
[task 2022-05-19T11:19:20.848Z] 11:19:20     INFO -  INFO timed-out       : False
[task 2022-05-19T11:19:20.857Z] 11:19:20     INFO -  Exit code: 2147483651
[task 2022-05-19T11:19:20.857Z] 11:19:20     INFO -  FAIL - self-test\delazification-mode-01.js

Set release status flags based on info from the regressing bug 1769871

status-firefox100: --- → unaffected
status-firefox101: --- → unaffected
status-firefox102: --- → affected
status-firefox-esr91: --- → unaffected

:nbp, since you are the author of the regressor, bug 1769871, could you take a look?
For more information, please visit auto_nag documentation.

Flags: needinfo?(nicolas.b.pierron)
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
Flags: needinfo?(nicolas.b.pierron)
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36984118ffb4
Skip delazification self-tests when code coverage is enabled. r=arai
Has Regression Range: --- → yes
Blocks: progressive-stencil

https://hg.mozilla.org/mozilla-central/rev/36984118ffb4

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch

This became perma now: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&fromchange=11b3a2e731a96457e518f5992abe5391d57e0857&searchStr=windows%2C10%2Cx64%2C2004%2Cccov%2Cwebrender%2Copt%2Ctest-windows10-64-2004-ccov-qr%2Fopt-jittest-1proc%2Cjit&selectedTaskRun=OmpZEWdkQoCqHNDCg1BmLw.0&tochange=1d31a009897964e94d43db5961ff68538d5e8ddb . Can you please take a look?
log 2: https://treeherder.mozilla.org/logviewer?job_id=378808236&repo=mozilla-central

Status: RESOLVED → REOPENED
status-firefox102: fixed → ---
Flags: needinfo?(nicolas.b.pierron)
Resolution: FIXED → ---
Summary: Intermittent tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand") [0.0 s] → Perma tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand") [0.0 s]
Target Milestone: 102 Branch → ---
Summary: Perma tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand") [0.0 s] → Perma [tier 2] tests\jit-test\jit-test\tests\self-test\delazification-mode-00.js | Unknown (code 2147483651, args "--delazification-mode=on-demand") [0.0 s]

Set release status flags based on info from the regressing bug 1769871

status-firefox102: --- → affected
Whiteboard: [retriggered]

So far I tried to compile the JS shell with --enable-coverage on NixOS and Ubuntu, and both are failing due to undefined code coverage symbols.
I tried to create an interactive task to run test-linux1804-64-ccov-qr/opt-jittest-1proc-6, but task cluster never present me with a shell / connection information which might help at reproducing this issue.

At the moment, I have no clue how to reproduce this issue in any way!

(In reply to Nicolas B. Pierron [:nbp] from comment #10)

I tried to create an interactive task to run test-linux1804-64-ccov-qr/opt-jittest-1proc-6, but task cluster never present me with a shell / connection information which might help at reproducing this issue.

Ok, I managed to find the shell / display web page artifacts which are generated, but I get neither a prompt nor a display.

Whiteboard: [retriggered] → [retriggered][stockwell needswork:owner]

The CLI options seems good while testing manually, or while fuzzing, but seems
to cause issues in CI which are hard to reproduce. None of our test cases are
using the CLI options as of today, and instead they all rely on the evaluate
function provided with a delazification mode.

This patch changes the usage to fit what our test suite is actually using for
testing instead of testing CLI options.

Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc0540200c1c
Self-test switch from CLI to evaluate options, to follow the test suite. r=arai
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e196f81f92a
Self-test switch from CLI to evaluate options, to follow the test suite. r=arai

Backed out changeset 0e196f81f92a (Bug 1770167) for causing SM bustages on delazification-mode-00.js.
Backout link
Push with failures
Failure Log

🤦 Pushing the old patch back to phabricator never helps at fixing issues.

Flags: needinfo?(nicolas.b.pierron)
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/283486d5e01d
Self-test switch from CLI to evaluate options, to follow the test suite. r=arai

https://hg.mozilla.org/mozilla-central/rev/283486d5e01d

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

The patch landed in nightly and beta is affected.
:nbp, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(nicolas.b.pierron)

Comment on attachment 9277456 [details]
Bug 1770167 - Skip delazification self-tests when code coverage is enabled.

Beta/Release Uplift Approval Request

  • User impact if declined: None
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a test case only modification, to avoid failures of code coverage on JS test suite.
  • String changes made/needed: None
  • Is Android affected?: No
Flags: needinfo?(nicolas.b.pierron)
Attachment #9277456 - Flags: approval-mozilla-beta?
Attachment #9279101 - Flags: approval-mozilla-beta?

Comment on attachment 9277456 [details]
Bug 1770167 - Skip delazification self-tests when code coverage is enabled.

This landed on Nightly102.

Attachment #9277456 - Flags: approval-mozilla-beta?

Comment on attachment 9279101 [details]
Bug 1770167 - Self-test switch from CLI to evaluate options, to follow the test suite.

test-only changes don't need approval

Attachment #9279101 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: