Closed Bug 1770188 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34128 - Fix visualViewport page values in iframe

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34128 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34128
Details from upstream follow.

David Bokan <bokan@chromium.org> wrote:

Fix visualViewport page values in iframe

The visualViewport in an iframe should be entirely independent of the
visualViewport of the root frame. Unfortunately pageLeft/pageTop
erroneously add the root frame's viewport offsets to the document
offset, even when inside an iframe. This CL fixes the issue so that
iframe's report only the document offset (since an iframe cannot be
zoomed, its visualViewport cannot have its own offset).

Bug: 1313970
Change-Id: I917bf72f645d105cdde86bf186e7bebd3741247e

Reviewed-on: https://chromium-review.googlesource.com/3651641
WPT-Export-Revision: 255e683894ff335747b045a31aecd55cc31d0319

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 4 subtests

Status Summary

Firefox

OK : 7[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 8[GitHub]
PASS : 21[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 22[GitHub]
ERROR: 2

Chrome

OK : 9
PASS : 22
FAIL : 1
ERROR: 1

Safari

OK : 10
PASS : 22
FAIL : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

  • /visual-viewport/viewport-resize-event-on-load-overflowing-page.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36ded7ffaee4 [wpt PR 34128] - Fix visualViewport page values in iframe, a=testonly https://hg.mozilla.org/integration/autoland/rev/ff59de5cb6bc [wpt PR 34128] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/36ded7ffaee4
https://hg.mozilla.org/mozilla-central/rev/ff59de5cb6bc

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.