Remove support for component/contract manifest entries and old module loader
Categories
(Core :: XPCOM, task)
Tracking
()
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(17 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
This system has been superseded by the new static module system, and keeping it in place adds considerable complexity to the component manager and XPConnect JS module loader. Since the latter is getting a major overhaul to deal with ES modules, which adds even more complexity, now seems like the time to remove support.
Assignee | ||
Comment 1•2 years ago
|
||
This apparently hasn't been used for a while and has bit rotted, but it's
necessary for some migrations in later patches.
Assignee | ||
Comment 2•2 years ago
|
||
This makes it easier to migrate some tests that use chrome manifest
registration. It lets us register JSMs as components in a similar way to how
we register them in static component manifests.
Assignee | ||
Comment 3•2 years ago
|
||
Assignee | ||
Comment 4•2 years ago
|
||
Assignee | ||
Comment 5•2 years ago
|
||
JS components are now always loaded from JSMs.
Assignee | ||
Comment 6•2 years ago
|
||
Assignee | ||
Comment 7•2 years ago
|
||
These tests just test XPConnect wrapping, and don't actually have anything to
do with component registration. There are simpler ways to get wrapping that
are just as effective.
Assignee | ||
Comment 8•2 years ago
|
||
Assignee | ||
Comment 9•2 years ago
|
||
Assignee | ||
Comment 10•2 years ago
|
||
Assignee | ||
Comment 11•2 years ago
|
||
It was for the sake of legacy extensions, which we don't care about, and
applies to contract
manifest entries, which are being removed.
Assignee | ||
Comment 12•2 years ago
|
||
Assignee | ||
Comment 13•2 years ago
|
||
It's the same global as JSMs now, and support is being removed in any case.
Assignee | ||
Comment 14•2 years ago
|
||
Assignee | ||
Comment 15•2 years ago
|
||
Assignee | ||
Comment 16•2 years ago
|
||
Assignee | ||
Comment 17•2 years ago
|
||
Assignee | ||
Comment 18•2 years ago
|
||
Comment 19•2 years ago
|
||
You should file a bug in Thunderbird to give them the heads up on this, assuming they have some of these module things.
Assignee | ||
Comment 20•2 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #19)
You should file a bug in Thunderbird to give them the heads up on this, assuming they have some of these module things.
I guess. I told them it was coming when I wrote the static component registration, but I couldn't find the bug where we talked about it. I thought I'd already filed a bug to remove it and we'd talked about it there, but I couldn't find one.
Updated•2 years ago
|
Comment 21•2 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2ab6b38e9457 Part 1a - Fix components.conf Categories property. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/677f9103993a Part 1b - Update MockRegistrar to allow registering JSMs similarly to static components. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/2a5a596b06de Part 2 - Migrate MacTouchBar to static component registration. r=mconley https://hg.mozilla.org/integration/autoland/rev/b53461ed3afe Part 3 - Migrate StartupRecorder to static component registration. r=florian https://hg.mozilla.org/integration/autoland/rev/b13b27de5838 Part 4 - Move system scope Blob/File tests from JS components to JSMs. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/4ab7a8d03742 Part 5 - Get rid of obsolete component test in test_import.js. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/7f932a6d1f41 Part 6 - Update XPConnect xpcshell tests to avoid unnecessary legacy component registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/fc6cfc9ff71d Part 8 - Remove legacy component registration for TestInterfaceJS. r=peterv https://hg.mozilla.org/integration/autoland/rev/4815c9bf5d04 Part 9 - Update VacuumParticipant test mocks to not use chrome manifests for registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/93b1b280d8ab Part 10 - Remove test_bug725015.js. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/a689a914e3d4 Part 11 - Update push service test_handler_service.js to not use chrome manifests for component registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/315935601dba Part 12 - Remove test for IDB global objects in JS component scope. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/510232f50605 Part 13 - Use category entries to test manifest process directives. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/c17fe8acff16 Part 14 - Update URILoader parent handler service to use static component registration. r=mconley https://hg.mozilla.org/integration/autoland/rev/2921011378ed Part 15 - Remove component/contract support from manifest parser. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/2bc9c047ee2e Part 16 - Remove component loading logic from mozJSComponentLoader. r=mccr8,florian https://hg.mozilla.org/integration/autoland/rev/d6b5a5936b57 Part 17 - Rename mozJSComponentLoader to mozJSModuleLoader r=mccr8,decoder
Comment 22•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2ab6b38e9457
https://hg.mozilla.org/mozilla-central/rev/677f9103993a
https://hg.mozilla.org/mozilla-central/rev/2a5a596b06de
https://hg.mozilla.org/mozilla-central/rev/b53461ed3afe
https://hg.mozilla.org/mozilla-central/rev/b13b27de5838
https://hg.mozilla.org/mozilla-central/rev/4ab7a8d03742
https://hg.mozilla.org/mozilla-central/rev/7f932a6d1f41
https://hg.mozilla.org/mozilla-central/rev/fc6cfc9ff71d
https://hg.mozilla.org/mozilla-central/rev/4815c9bf5d04
https://hg.mozilla.org/mozilla-central/rev/93b1b280d8ab
https://hg.mozilla.org/mozilla-central/rev/a689a914e3d4
https://hg.mozilla.org/mozilla-central/rev/315935601dba
https://hg.mozilla.org/mozilla-central/rev/510232f50605
https://hg.mozilla.org/mozilla-central/rev/c17fe8acff16
https://hg.mozilla.org/mozilla-central/rev/2921011378ed
https://hg.mozilla.org/mozilla-central/rev/2bc9c047ee2e
https://hg.mozilla.org/mozilla-central/rev/d6b5a5936b57
Comment 23•2 years ago
|
||
backout bugherder uplift |
Backed out of 103 beta for introducing Bug 1776207
https://hg.mozilla.org/releases/mozilla-beta/rev/f3185e137745
Updated•2 years ago
|
Updated•2 years ago
|
Description
•