1770288 - Intermittent toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js | single tracking bug

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mlaza [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=378711220&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Whn07pgrQniZmrgRvNbo5A/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-05-20T02:01:24.231Z] 02:01:24     INFO -  TEST-START | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js
[task 2022-05-20T02:01:24.309Z] 02:01:24     INFO -  adb launch_application: am startservice -W -n 'org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.XpcshellTestRunnerService$i0' -a android.intent.action.MAIN --es env0 XPCOM_DEBUG_BREAK=stack-and-abort --es env1 MOZ_CRASHREPORTER=1 --es env2 MOZ_CRASHREPORTER_NO_REPORT=1 --es env3 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es env4 MOZ_DEVELOPER_REPO_DIR=/builds/worker/checkouts/gecko --es env5 MOZ_DISABLE_CONTENT_SANDBOX=1 --es env6 MOZ_FETCHES_DIR=/builds/worker/fetches --es env7 MOZ_DISABLE_SOCKET_PROCESS=1 --es env8 LD_LIBRARY_PATH=/data/local/tmp/test_root/xpcb --es env9 MOZ_LINKER_CACHE=/data/local/tmp/test_root/xpcb --es env10 GRE_HOME=/data/local/tmp/test_root/xpcb --es env11 XPCSHELL_TEST_PROFILE_DIR=/data/local/tmp/test_root/xpc/p/7d52632e-9eec-404c-a21f-87823238dcf8 --es env12 HOME=/data/local/tmp/test_root/xpc/p --es env13 XPCSHELL_TEST_TEMP_DIR=/data/local/tmp/test_root/xpc/tmp/2149e730-3b90-4a23-96cc-ceb9bb4c5fda --es env14 MOZ_ANDROID_DATA_DIR=/data/local/tmp/test_root/xpcb --es env15 MOZ_IN_AUTOMATION=1 --es env16 MOZ_ANDROID_CPU_ABI=x86_64 --es env17 MOZHTTP2_PORT=36829 --es env18 MOZNODE_EXEC_PORT=32995 --es env19 TMPDIR=/data/local/tmp/test_root/xpc/p/7d52632e-9eec-404c-a21f-87823238dcf8 --es env20 XPCSHELL_MINIDUMP_DIR=/data/local/tmp/test_root/xpc/minidumps/7d52632e-9eec-404c-a21f-87823238dcf8 --es arg0 -g --es arg1 /data/local/tmp/test_root/xpcb --es arg2 --greomni --es arg3 /data/local/tmp/test_root/xpcb/geckoview-test_runner.apk --es arg4 -m --es arg5 -e --es arg6 'const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js";' --es arg7 -e --es arg8 'const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/7d52632e-9eec-404c-a21f-87823238dcf8/mozinfo.json";' --es arg9 -e --es arg10 'const _PREFS_FILE = "/data/local/tmp/test_root/xpc/tmp/2149e730-3b90-4a23-96cc-ceb9bb4c5fda/user.js";' --es arg11 -e --es arg12 'const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m";' --es arg13 -f --es arg14 /data/local/tmp/test_root/xpc/head.js --es arg15 -e --es arg16 'const _HEAD_FILES = ["/data/local/tmp/test_root/xpc/toolkit/components/extensions/test/xpcshell/head.js", "/data/local/tmp/test_root/xpc/toolkit/components/extensions/test/xpcshell/head_telemetry.js", "/data/local/tmp/test_root/xpc/toolkit/components/extensions/test/xpcshell/head_sync.js", "/data/local/tmp/test_root/xpc/toolkit/components/extensions/test/xpcshell/head_storage.js"];' --es arg17 -e --es arg18 'const _JSDEBUGGER_PORT = 0;' --es arg19 -e --es arg20 'const _TEST_CWD = "/data/local/tmp/test_root/xpc/toolkit/components/extensions/test/xpcshell";' --es arg21 -e --es arg22 'const _TEST_FILE = ["test_ext_extension_page_navigated.js"];' --es arg23 -e --es arg24 'const _TEST_NAME = "xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js";' --es arg25 -e --es arg26 '_execute_test(); quit(0);' --ez use_multiprocess True --es out_file /data/local/tmp/test_root/xpc/logs/xpcshell-bd1698f0-444d-47d8-b82c-54e1df0a85fc.log
[task 2022-05-20T02:01:24.566Z] 02:01:24     INFO -  remotexpcshelltests.py | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js | 30261 | Launched Test App
[task 2022-05-20T02:01:32.388Z] 02:01:32     INFO -  remotexpcshelltests.py | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js | 30261 | Application ran for: 0:00:08.156955
[task 2022-05-20T02:01:32.479Z] 02:01:32  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js | xpcshell return code: 0
[task 2022-05-20T02:01:32.479Z] 02:01:32     INFO -  TEST-INFO took 8248ms
[task 2022-05-20T02:01:32.479Z] 02:01:32     INFO -  >>>>>>>
[task 2022-05-20T02:01:32.479Z] 02:01:32     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-05-20T02:01:32.480Z] 02:01:32     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-05-20T02:01:32.480Z] 02:01:32     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-05-20T02:01:32.480Z] 02:01:32     INFO -  running event loop
[task 2022-05-20T02:01:32.480Z] 02:01:32     INFO -  xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js | Starting setup check_remote
[task 2022-05-20T02:01:32.480Z] 02:01:32     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2022-05-20T02:01:32.481Z] 02:01:32     INFO -  TEST-PASS | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - false == false

Comment 1

[Andreea Pavel [:apavel]]

Hi Luca, can this be a regression of bug 1739114?

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Andreea Pavel [:apavel] from comment #1)

Hi Luca, can this be a regression of bug 1739114?

I'm pretty sure that it is unrelated to the commit we landed from bug 1739114 today.

Looking to the failure logs, I see that the test did fail because RemoteSettings has tried to fetch data from the fake url set in the xpcshell test manifest prefs, that may happen at any time based on when RemoteSettings schedule it behind the scene and it seems that it managed to happen exactly while the test was collecting the console messages that are then being checked using AddonTestUtils.checkMessages and that triggered an intermittent failure:

TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_extension_page_navigated.js | test_extension_page_sameprocess_navigation - [test_extension_page_sameprocess_navigation : 1650] Got forbidden console message: [JavaScript Error: "NetworkError: Network request failed" {file: "resource://services-settings/Utils.jsm" line: 153}]
  fetch/</request.onerror@resource://services-settings/Utils.jsm:153:26
  _do_main@/data/local/tmp/test_root/xpc/head.js:240:6
  _execute_test@/data/local/tmp/test_root/xpc/head.js:597:5
  @-e:1:1
   - false == true
  resource://testing-common/AddonTestUtils.jsm:checkMessages:1650
  test_ext_extension_page_navigated.js:test_extension_page_sameprocess_navigation:203

We should make the test to don't fail on these completely unrelated console messages, I'll take care of it.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1770288 - Fix intermittent failure on unrelated unexpected console message in test_ext_extension_page_navigated.js. r?willdurand!

The intermittent failure triggered by this test is due to use of the wrong type signature for the AddonTestUtils.checkMessages
forbidden option, which expects the regular expression to be set as the value of the console message property that should be
checked against the regular expression.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1770288 - Fix wrong parameter type signature in AddonTestUtils.checkMessages call in browser_ext_tabs_insertCSS.js. r?willdurand!

This other call to AddonTestUtils.checkMessage is also using a forbidden option wrongly set to the regular expression,
and the manual messages.filter(...) is definitely a workaround for preventing an intermittent similar to the one
fixed in the other patch. Better to fix this other call even if not strictly related to this bugzilla issue.

Depends on D146935

Comment 5

[Intermittent Failures Robot]

5 failures in 2694 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5

Platform and build breakdown:

• android-em-7-0-x86_64-qr: 3
  • debug: 3
• android-em-7-0-x86_64-lite-qr: 2
  • debug: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1770288&startday=2022-05-16&endday=2022-05-22&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df2f55991762
Fix intermittent failure on unrelated unexpected console message in test_ext_extension_page_navigated.js. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/b08121c50333
Fix wrong parameter type signature in AddonTestUtils.checkMessages call in browser_ext_tabs_insertCSS.js. r=willdurand

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/df2f55991762
https://hg.mozilla.org/mozilla-central/rev/b08121c50333

Comment 8

[Intermittent Failures Robot]

1 failures in 2624 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• android-em-7-0-x86_64-lite-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1770288&startday=2022-05-23&endday=2022-05-29&tree=all