1770331 - Sorting input history using use_count in Adaptive History Autofill and UrlbarProviderInputHistory may be wrong

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Daisuke Akatsuka (:daisuke)]

Currently, we store input history data as is = case-sensitive. That means if user visits https://www.mozilla.org/contribute/ by user’s input m and visits the same URL by M is stored as different record.
As Adaptive History Autofill and UrlbarProviderInputHistory sort the table with case-insensitive using use_count, above m and M is handled as different data even the URL is same. Therefore, the sorting may be wrong.

Comment 1

[Drew Willcoxon :adw]

Just to provide more info here in the bug, see also the discussion in https://phabricator.services.mozilla.com/D146864#4802384 and later comments.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1770331: Store user's input in moz_inputhistory as lower case.

Comment 3

[Marco Bonardo [:mak]]

I was tagged in the original review, so far I agree with storing lowercase.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49a45dfe12aa
Store user's input in moz_inputhistory as lower case. r=adw,mak

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/49a45dfe12aa

Comment 6

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello

Confirming this issue as verified fixed on 103.0a1(20220616190155) and 102.0b9-build1 (20220616185542) using macOS 11.6.6, Ubuntu 20 and Windows 11.