1770448 - Exception logged if you install an extension that provides a search-only address book

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[[e-mail]]

NS_ERROR_NOT_IMPLEMENTED: ExtSearchBook does not implement childCardCount getter.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Added the getter to match nsIAbDirectory property order.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9277503 [details] [diff] [review]
Proposed patch

What's trying to access this without a try/catch? There's only one caller AFAIK, and it should silently catch the exception.

Comment 3

[[e-mail]]

(In reply to Geoff Lankow from comment #2)

What's trying to access this without a try/catch? There's only one caller AFAIK, and it should silently catch the exception.

Typical, I've since updated my tree, and it's not logging anything any more.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d50189e6b312
Add childCardCount implementation to ExtSearchBook r=darktrojan

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9277503 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 1753180
User impact if declined:
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low risk, just adds a getter function that was missing.

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9277503 [details] [diff] [review]
Proposed patch

[Triage Comment]
Approved for beta.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.0beta7:
https://hg.mozilla.org/releases/comm-beta/rev/5813212d858f