1770492 - Support primitive values as "arguments" for "script.callFunction" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

With bug 1750541 we will get basic support for script.callFunction. This bug covers the addition of handling the arguments parameter and the creation of appropriate webdriver and maybe xpcshell tests.

Depending on the implementation status of deserializing of local values the scope for this bug might have to be cut-down to just primitive protocol values. If that's the case we should split out the remaining work to another bug.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770492 - [bidi] Support basic "arguments" for "script.callFunction" command

Depends on D150822

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770492 - [messagehandler] Support emitting protocol errors from MessageHandler modules

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1770492 - [bidi] RemoteValue deserialize should throw when type is not a string

Depends on D151034

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db9d816614fb
[messagehandler] Support emitting protocol errors from MessageHandler modules r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/29be55402599
[bidi] RemoteValue deserialize should throw when type is not a string r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/f2734a746b1a
[bidi] Support basic "arguments" for "script.callFunction" command r=webdriver-reviewers,whimboo

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/db9d816614fb
https://hg.mozilla.org/mozilla-central/rev/29be55402599
https://hg.mozilla.org/mozilla-central/rev/f2734a746b1a

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

We should include the enhancements for Javascript Object deserialization into our release notes but do not want to mention the script.callFunction command given that it is still experimental.