If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

fix all openers of the advanced ab search dialog to open a new dialog (if one is not already open), or raise the existing one (if it exists)

RESOLVED FIXED

Status

SeaMonkey
MailNews: Address Book & Contacts
--
trivial
RESOLVED FIXED
15 years ago
13 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: Stefan Borggraefe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.96 KB, patch
neil@parkwaycc.co.uk
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
On the trunk, Tools | Search | Search Addressess.. brings the top most search
dialog to focus, but in all other access points, we bring up a new search dialog.

we should make all openers act the same.

Currently, we appear to handle multiple search dialogs correctly.

We should ask jglick what she wants.  Something to keep in mind is there might
be a compelling reason one day to just support one dialog, like there is for
mail search.

Comment 1

15 years ago
Unless there is a compelling reason to bring up a new search dialog instead of 
giving focus to an existing, already open dialog, i'd recommend the more simple 
ui of bringing forward the already open dialog.
taking all of varada's bugs.
Assignee: varada → sspitzer
(Assignee)

Comment 3

14 years ago
Created attachment 150600 [details] [diff] [review]
Fixes both TB and SM
Assignee: sspitzer → Stefan.Borggraefe
Status: NEW → ASSIGNED
(Assignee)

Updated

14 years ago
Severity: normal → trivial
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Updated

14 years ago
Attachment #150600 - Flags: review?(neil.parkwaycc.co.uk)

Comment 4

14 years ago
Comment on attachment 150600 [details] [diff] [review]
Fixes both TB and SM

Nit: line up .getService with .classes
Attachment #150600 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Comment 5

14 years ago
Comment on attachment 150600 [details] [diff] [review]
Fixes both TB and SM

I'll address Neil's nit before checkin. Asking Seth for sr, because he reported
this bug.
Attachment #150600 - Flags: superreview?(sspitzer)
(Assignee)

Updated

13 years ago
Attachment #150600 - Flags: superreview?(sspitzer) → superreview?(mscott)
Summary: fix all openers of the advanced ab search dialog to open a new dialog (even if one exists), or raise the existing one (if it exists) → fix all openers of the advanced ab search dialog to open a new dialog (if one is not already open), or raise the existing one (if it exists)
Comment on attachment 150600 [details] [diff] [review]
Fixes both TB and SM

thanks for fixing this stefan.

sr=sspitzer for SM, but you will need a=mscott for tbird.
Attachment #150600 - Flags: superreview?(mscott) → superreview+
(Assignee)

Comment 7

13 years ago
Thanks Seth! :-)

Scott, can you give moa for the TB part of this patch?

Comment 8

13 years ago
sure...looks good :)
(Assignee)

Comment 9

13 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.