1770540 - JavaScript error: resource:///modules/calendar/Ical.jsm, line 5595: InternalError: too much recursion logged to console during browser_alarmDialog.js

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Lasana Murray]

The ical.js backend contains a circular reference and throws an exception if you try to JSON.stringify() it. It would be better to provide the toString() value instead.

JavaScript error: resource:///modules/calendar/Ical.jsm, line 5595: InternalError: too much recursion                                  
 0:14.10 PASS [object XULElement] == true -           
 0:14.14 INFO Console message: [JavaScript Error: "InternalError: too much recursion" {file: "resource:///modules/calendar/Ical.jsm" line: 5595}]
icaltime_adjust@resource:///modules/calendar/Ical.jsm:5595:37
setTimeAttr@resource:///modules/calendar/Ical.jsm:5792:18                     
fromData@resource:///modules/calendar/Ical.jsm:5015:13
icaltime@resource:///modules/calendar/Ical.jsm:4877:10
clone@resource:///modules/calendar/Ical.jsm:4927:14                           
startOfWeek@resource:///modules/calendar/Ical.jsm:5103:25
get startOfWeek@resource:///components/calDateTime.js:164:45
getMessage@resource://testing-common/Assert.jsm:77:19                                                                                                         
Assert.AssertionError@resource://testing-common/Assert.jsm:122:18                                                                                             
proto.report@resource://testing-common/Assert.jsm:215:13       
proto.ok@resource://testing-common/Assert.jsm:254:10

Comment 1

[Lasana Murray]

I think what's happening here is that get startOfWeek returns a datetime instance which has no toJSON() method built in so it will go through structured cloning which will result in get startOfWeek being called again and again until we hit too much recursion. These getters really are a gentle path to chaos.

Comment 2

[Lasana Murray]

Attachment: Bug 1770540 - Add toJSON() to calDateTime api for better stringifying. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d041abce5e6
Add toJSON() to calDateTime api for better stringifying. r=thunderbird-reviewers,darktrojan