1770727 - Finish enabling all ESLint rules on sjs files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

I've a few patches to finish the roll-out of ESLint rules to sjs files.

Comment 1

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=65d8aa8dc9b9f52556c253744ea6ad1d855c60e0

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1770727 - Fix some more ESLint rules on sjs files. r?Gijs

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1770727 - Fix ESLint rule mozilla/use-services on sjs files and expose Services to sjs files. r?Gijs

Depends on D147080

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1770727 - Fix failures of ESLint rule mozilla/use-includes-instead-of-indexOf in sjs files. r?Gijs

Depends on D147081

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1770727 - Fix remaining ESLint rules for sjs files. r?Gijs

Depends on D147082

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/464d1af6523b
Fix some more ESLint rules on sjs files. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/2a358ba86652
Fix ESLint rule mozilla/use-services on sjs files and expose Services to sjs files. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/fc7ea80aa2ff
Fix failures of ESLint rule mozilla/use-includes-instead-of-indexOf in sjs files. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/6323b526b0ac
Fix remaining ESLint rules for sjs files. r=Gijs,necko-reviewers,kershaw

Comment 7

[Sandor Molnar[:smolnar]]

Backed out 4 changesets (bug 1770727) for causing mochitest failures in test_bug1180105/test_access_control. CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/95bed6ba43a502cbae0b0775c61456c75a67d683

Push with failures

Failure log mochitest plain

Failure log mda

INFO -  TEST-START | image/test/mochitest/test_bug1180105.html
[task 2022-05-24T13:48:37.014Z] 13:48:37  WARNING -  TEST-UNEXPECTED-FAIL | image/test/mochitest/test_bug1180105.html | Test timed out. -
[task 2022-05-24T13:48:37.015Z] 13:48:37  WARNING -  TEST-UNEXPECTED-FAIL | image/test/mochitest/test_bug1180105.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.)
[task 2022-05-24T13:48:37.015Z] 13:48:37     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-05-24T13:48:37.015Z] 13:48:37     INFO -      afterCleanup@SimpleTest/SimpleTest.js:1416:18
[task 2022-05-24T13:48:37.015Z] 13:48:37     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1481:7
[task 2022-05-24T13:48:37.015Z] 13:48:37     INFO -      SimpleTest.finish@SimpleTest/SimpleTest.js:1501:3
[task 2022-05-24T13:48:37.015Z] 13:48:37     INFO -      killTest@SimpleTest/TestRunner.js:194:22

Comment 8

[Mark Banner (:standard8)]

Andrew, I'm making a change to httpd.js and as a result I think hostutils needs to be updated for me to land this. Would you be able to update it for me please?

Comment 9

[Andrew Erickson [:aerickson]]

Yes, will do. Created Bug 1771520.

Comment 10

[Mark Banner (:standard8)]

Attachment: Bug 1770727 - Update Linux hostutils. r?aerickson

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/2d6314194ba8
Fix some more ESLint rules on sjs files. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/2d7a867faa65
Fix ESLint rule mozilla/use-services on sjs files and expose Services to sjs files. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/e31780810a6f
Fix failures of ESLint rule mozilla/use-includes-instead-of-indexOf in sjs files. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/21b8a9b8b705
Fix remaining ESLint rules for sjs files. r=Gijs,necko-reviewers,kershaw

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2d6314194ba8
https://hg.mozilla.org/mozilla-central/rev/2d7a867faa65
https://hg.mozilla.org/mozilla-central/rev/e31780810a6f
https://hg.mozilla.org/mozilla-central/rev/21b8a9b8b705