1770766 - Profiler's marker chart rendering is broken by bug 1770088

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Julien Wajsberg [:julienw]]

STR:

1. Open https://profiler.firefox.com/public/dss4w1ezqaacmneaar26h980xqwap22eskcd3j0/marker-chart/?globalTrackOrder=021&hiddenGlobalTracks=0&localTrackOrderByPid=2981406-120~3012339-01&thread=2&timelineType=cpu-category&v=6
2. Hover on some markers.

=> Notice how their borders aren't rendered anymore.
Actually it looks like the border is already wrong on the hover (isHighlighted case in the code below).

mozregression pointed to bug 1770088.

The code responsible for these drawings is https://github.com/firefox-devtools/profiler/blob/fe13f1f5e9d2205b2b6bde46d3080e7be3d277e0/src/components/marker-chart/Canvas.js#L303-L320

What's confusing to me is that this works well for the first rendering.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1770088

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:lsalzman, since you are the author of the regressor, bug 1770088, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Lee Salzman [:lsalzman]]

Can you post a screenshot? It seems to be working fine here when I try.

Comment 4

[Julien Wajsberg [:julienw]]

Attachment: Screencast_20220523_183412.webm

You can see what's happening for me in this video.

Comment 5

[Julien Wajsberg [:julienw]]

Attachment: about:support

Comment 6

[Julien Wajsberg [:julienw]]

Attachment: about-support.json

Comment 7

[Lee Salzman [:lsalzman]]

Okay, I can confirm that this is happening seemingly only at 100% scale, wherein accelerated line drawing gets done that is somehow buggy...

Comment 8

[Lee Salzman [:lsalzman]]

Attachment: Bug 1770766 - Use native AA only for native lines in DrawTargetWebgl. r?aosmond

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63964e5c364d
Use native AA only for native lines in DrawTargetWebgl. r=aosmond,gfx-reviewers

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/63964e5c364d