1770845 - Fix non-unified build error in gfx/thebes/gfxMacPlatformFontList.mm

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect, P3)

Description

[Chris Peterson [:cpeterson]]

This build error was a regression from bug 1743170. The code that used kDeprecatedFontFamilies was wrapped with #ifdef USE_DEPRECATED_FONT_FAMILY_NAMES, but the definition of kDeprecatedFontFamilies wasn't so the compiler thinks kDeprecatedFontFamilies is unused.

gfx/thebes/gfxMacPlatformFontList.mm:92:28: error: unused variable 'kDeprecatedFontFamilies' [-Werror,-Wunused-const-variable]
constexpr nsLiteralCString kDeprecatedFontFamilies[] = {

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1770845 - Fix non-unified build error in gfx/thebes/gfxMacPlatformFontList.mm. r?jfkthame!,#gfx-reviewers

This build error was a regression from bug 1743170. The code that used kDeprecatedFontFamilies was wrapped with #ifdef USE_DEPRECATED_FONT_FAMILY_NAMES, but the definition of kDeprecatedFontFamilies wasn't so the compiler thinks kDeprecatedFontFamilies is unused.

gfx/thebes/gfxMacPlatformFontList.mm:92:28: error: unused variable 'kDeprecatedFontFamilies' [-Werror,-Wunused-const-variable]
constexpr nsLiteralCString kDeprecatedFontFamilies[] = {

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug is a defect, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b37fd715d031
Fix non-unified build error in gfx/thebes/gfxMacPlatformFontList.mm. r=jfkthame,gfx-reviewers,lsalzman

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b37fd715d031