Closed Bug 1770959 Opened 3 months ago Closed 2 months ago

Debugger parse URL via whatwg-url module and is slow

Categories

(DevTools :: Debugger, enhancement)

enhancement

Tracking

(firefox102 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The debugger uses whatwg-url from a unique callsite over there:
https://searchfox.org/mozilla-central/rev/1c391443f770eddc7cde9e52dba5ef50cc233c06/devtools/client/debugger/src/utils/url.js#5
But this is called for parsing lots of URLs and appears to be slow.
It looks like moving to parse the URL via the URL constructor is much faster. At least it no longer appears as a major cost in the profiler.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Attachment #9277970 - Attachment description: Bug 1770959 - Use standard URL constructor instead of whatwg-url module → Bug 1770959 - [devtools] Use standard URL constructor instead of whatwg-url module.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf5baa8bec21
[devtools] Use standard URL constructor instead of whatwg-url module. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.