1770968 - Pinned tabs are not correctly handled when the number of normal tabs overflows

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dan Robertson (:dlrobertson)]

Steps to Reproduce:

• pin at least two tabs
• click new tab until the tabs overflow

Expected behavior:

• pinned tabs stay in place and normal tabs overflow

Actual results:

• pinned tabs are shown under the close/expand/minimize buttons

This can also be reproduced with the following:

• click new tab until the tabs overflow
• create two new tabs and pin them

I've tested on Mac, but have not tested any other platforms.

First noticed on: 102.0a1 (2022-05-24) (64-bit)

Comment 1

[Dan Robertson (:dlrobertson)]

mozregression gave me https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cf63538fe82cdf094b73fd5ce7c9ef7f6bfdf9e8&tochange=9e4593ef59f1f00ab05810758c96192427691bc4

Comment 2

[Andrew McCreight [:mccr8]]

[Tracking Requested - why for this release]: This makes Firefox pretty unusable for me.

I'm also on OSX. A workaround is to maximize the window and then the weird flickering stops.

Comment 3

[Andrew McCreight [:mccr8]]

For me, the resulting behavior is worse than described in comment 0. I have 12 pinned tabs and a dozen regular tabs. Basically whenever I move the mouse the entire tab bar completely freaks out, like it is rapidly recalculating the entire tab bar.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1770808

Comment 5

[Andrew McCreight [:mccr8]]

Ok, it looks like maximizing the window doesn't actually fix the issue per se. It just made the window wide enough that all of the tabs could fit in the window. I opened a few more tabs and then it started happening while maximized.

Comment 6

[Cosmin Sabou [:CosminS]]

Regressor was backed out from central, new desktop nightlies incoming: https://bugzilla.mozilla.org/show_bug.cgi?id=1770808#c5

Comment 7

[Andrew McCreight [:mccr8]]

Aryx wasn't able to reproduce in Windows 8.1. Maybe it is OSX specific?

Comment 8

[Dan Robertson (:dlrobertson)]

(In reply to Andrew McCreight [:mccr8] from comment #3)

For me, the resulting behavior is worse than described in comment 0. I have 12 pinned tabs and a dozen regular tabs. Basically whenever I move the mouse the entire tab bar completely freaks out, like it is rapidly recalculating the entire tab bar.

I am also able to reproduce this with ~6 pinned tabs

Comment 9

[Andrew McCreight [:mccr8]]

Another report of this from somebody on the MoCo slack, also on OSX.

Comment 10

[:Gijs (he/him)]

The original patch was backed out and a fixed version relanded. Can you confirm this is fixed for you on tomorrow morning's nightly, and close this out as WFM if so?

Comment 11

[Dan Robertson (:dlrobertson)]

+1 Thanks!