Bootstrap mozconfig-suggestion-output is missing a final newline, resulting in `<<<` smooshed together with your shell prompt
Categories
(Firefox Build System :: Bootstrap Configuration, defect)
Tracking
(firefox102 fixed)
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: dholbert, Assigned: ahochheiden)
Details
Attachments
(3 files)
screenshot
STR:
- Run ./mach bootstrap
- Choose option 4 (Firefox for Android)
- Proceed through the prompts. When the process completes, look at your terminal.
ACTUAL RESULTS:
The last few lines of output are:
Your system should be ready to build GeckoView/Firefox for Android!
Paste the lines between the chevrons (>>> and <<<) into
/home/dholbert/.mozconfigs/debug:
>>>
# Build GeckoView/Firefox for Android:
ac_add_options --enable-application=mobile/android
# Targeting the following architecture.
# For regular phones, no --target is needed.
# For x86 emulators (and x86 devices, which are uncommon):
# ac_add_options --target=i686
# For newer phones or Apple silicon
# ac_add_options --target=aarch64
# For x86_64 emulators (and x86_64 devices, which are even less common):
# ac_add_options --target=x86_64
<<<[dholbert@papaya:~/builds/mozilla-central/mozilla]$
Note the <<< sharing the same line as my shell prompt.
EXPECTED RESULTS:
Bootstrap should emit a newline after <<< so that my shell prompt can appear on its own line.
|
Reporter | |
Comment 1•2 years ago
|
||
|
|
Reporter | |
Comment 2•2 years ago
|
||
Actually, I can reproduce this with option 1 (Firefox for Desktop Artifact Mode), too.
(Note: In order to get this output, you might need to have the environmental variable MOZCONFIG=/path/to/some/mozconfig, and I suspect that mozconfig needs to be missing the relevant suggested mozconfig lines, perhaps.)
|
|
Reporter | |
Updated•2 years ago
|
|
Assignee | |
Comment 3•2 years ago
|
||
I was only able to reproduce this on Ubuntu, not on Windows. I assume that's how it was introduced in the first place (was only every tested on Windows).
It's not obvious why there's a discrepancy between the two platforms, but I don't think it's worth investigating. The simple fix is just having an extra new line on Windows so that it looks correct on Linux.
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by ahochheiden@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a83a2d453bde Remove the `.strip()` from the MOZCONFIG_SUGGESTION_TEMPLATE so that a newline is output before the shell prompt r=dholbert
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
Description
•