1771079 - TPS - validate is not a function (try 2)

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

In bug 1765743, @irios reported:

[phase phase1] RunNextTestAction failed - TypeError: this.pingValidator.validate is not a function(resource://tps/tps.jsm:1206:41) JS

and in that bug I fixed a different TPS failure, not this one :/ I managed to reproduce this by setting the preference testing.tps.skipPingValidation to false, which is how it is run for iOS. Tthe code that tried to short-circuit the validator was broken, because this.pingValidator wasn't a function for a property. The attached patch fixes it.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1771079 - fix TPS when sync ping validation is disabled. r?LougeniaBailey

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be5753a74043
fix TPS when sync ping validation is disabled. r=LougeniaBailey

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/be5753a74043

Comment 4

[Isabel Rios[:isabel_rios]]

I confirm that FxA-Sync iOS tests are working again, thanks for the fix!