1771117 - Distinguish between system (privileged) esm files and non-system in ESLint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

When we initially added support for ESM-ified modules, we added a first guess to get something supported for experimenting/testing.

We have now decided on using .sys.mjs for system/privileged ESM files, and .mjs for other ESM files.

We therefore need to separate out what we expect as system/privileged in the ESLint recommended configuration - currently all .mjs files are assumed to be system.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1771117 - Distingish between system (privileged) mjs files and non-system ones in ESLint. r?arai

Depends on D148754

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e447fe3c1f91
Distingish between system (privileged) mjs files and non-system ones in ESLint. r=arai

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e447fe3c1f91

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 9280423 [details]
Bug 1771117 - Distingish between system (privileged) mjs files and non-system ones in ESLint. r?arai

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Lint-only change which improves the distinction between non-system and system module files. The decision to split the naming of these files happened just after 102 was branched.

This should help if uplifts of module files are needed, and also will help external developers who are working with the 102 branch.

• User impact if declined: None
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky - linting only.

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9280423 [details]
Bug 1771117 - Distingish between system (privileged) mjs files and non-system ones in ESLint. r?arai

Approved for 102.1esr.

Comment 6

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/0655f367d2bf