Closed Bug 1771117 Opened 3 months ago Closed 2 months ago

Distinguish between system (privileged) esm files and non-system in ESLint

Categories

(Developer Infrastructure :: Lint and Formatting, task, P2)

Tracking

(firefox-esr102 fixed, firefox103 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
firefox-esr102 --- fixed
firefox103 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When we initially added support for ESM-ified modules, we added a first guess to get something supported for experimenting/testing.

We have now decided on using .sys.mjs for system/privileged ESM files, and .mjs for other ESM files.

We therefore need to separate out what we expect as system/privileged in the ESLint recommended configuration - currently all .mjs files are assumed to be system.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e447fe3c1f91
Distingish between system (privileged) mjs files and non-system ones in ESLint. r=arai
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch

Comment on attachment 9280423 [details]
Bug 1771117 - Distingish between system (privileged) mjs files and non-system ones in ESLint. r?arai

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Lint-only change which improves the distinction between non-system and system module files. The decision to split the naming of these files happened just after 102 was branched.

This should help if uplifts of module files are needed, and also will help external developers who are working with the 102 branch.

  • User impact if declined: None
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky - linting only.
Attachment #9280423 - Flags: approval-mozilla-esr102?

Comment on attachment 9280423 [details]
Bug 1771117 - Distingish between system (privileged) mjs files and non-system ones in ESLint. r?arai

Approved for 102.1esr.

Attachment #9280423 - Flags: approval-mozilla-esr102? → approval-mozilla-esr102+
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.