Closed Bug 1771126 Opened 4 months ago Closed 2 months ago

Migrate remaining strings in resetProfile.dtd to Fluent

Categories

(Toolkit :: General, task)

task

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: flod, Assigned: eemeli)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Bug 1517307 only left a couple of strings in the file.

Initially this seemed trivial, then I noticed why these strings were left behind (and, AFAIK, no follow-up bug was filed).
https://phabricator.services.mozilla.com/D17416

The strings aren't displaying in this dialog, and adding the DOM localization initialization code such as https://searchfox.org/mozilla-central/rev/60c4067b1cbb0f94d7dc2d7cdfa27ed579817fee/browser/components/nsBrowserGlue.js#1010-1016 is throwing an exception that the sources are already registered.

Blocks: 1581212
Summary: Convert remaining strings in resetProfile.dtd to Fluent → Migrate remaining strings in resetProfile.dtd to Fluent
Assignee: nobody → earo
Status: NEW → ASSIGNED

I'm not sure what might have been the issue with solving this "trivially" previously, but the now-submitted patch seems to work?

That is, at least according to the treeherder job generated by mach try auto and by inspecting the chrome://global/content/resetProfileProgress.xhtml page directly.

Is there a way to trigger the profile-refresh flow manually, and to then pause it while displaying the progress dialog?

Flags: needinfo?(jaws)
Pushed by earo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58b31341edc3
Migrate resetProfileProgress strings from DTD to FTL. r=fluent-reviewers,flod,jaws
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch

(In reply to Eemeli Aro [:eemeli] from comment #2)

I'm not sure what might have been the issue with solving this "trivially" previously, but the now-submitted patch seems to work?

That is, at least according to the treeherder job generated by mach try auto and by inspecting the chrome://global/content/resetProfileProgress.xhtml page directly.

Is there a way to trigger the profile-refresh flow manually, and to then pause it while displaying the progress dialog?

In the browser console, you can type window.open("chrome://global/content/resetProfileProgress.xhtml", "", "chrome,width=600,height=300");

Flags: needinfo?(jaws)
Blocks: 1786543
You need to log in before you can comment on or make changes to this bug.