1771126 - Migrate remaining strings in resetProfile.dtd to Fluent

Status: RESOLVED FIXED

(Toolkit :: General, task)

Description

[Francesco Lodolo [:flod]]

Bug 1517307 only left a couple of strings in the file.

Initially this seemed trivial, then I noticed why these strings were left behind (and, AFAIK, no follow-up bug was filed).
https://phabricator.services.mozilla.com/D17416

The strings aren't displaying in this dialog, and adding the DOM localization initialization code such as https://searchfox.org/mozilla-central/rev/60c4067b1cbb0f94d7dc2d7cdfa27ed579817fee/browser/components/nsBrowserGlue.js#1010-1016 is throwing an exception that the sources are already registered.

Comment 1

[Eemeli Aro [:eemeli]]

Attachment: Bug 1771126 - Migrate resetProfileProgress strings from DTD to FTL. r=MattN

Comment 2

[Eemeli Aro [:eemeli]]

I'm not sure what might have been the issue with solving this "trivially" previously, but the now-submitted patch seems to work?

That is, at least according to the treeherder job generated by mach try auto and by inspecting the chrome://global/content/resetProfileProgress.xhtml page directly.

Is there a way to trigger the profile-refresh flow manually, and to then pause it while displaying the progress dialog?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58b31341edc3
Migrate resetProfileProgress strings from DTD to FTL. r=fluent-reviewers,flod,jaws

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/58b31341edc3

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Eemeli Aro [:eemeli] from comment #2)

I'm not sure what might have been the issue with solving this "trivially" previously, but the now-submitted patch seems to work?

That is, at least according to the treeherder job generated by mach try auto and by inspecting the chrome://global/content/resetProfileProgress.xhtml page directly.

Is there a way to trigger the profile-refresh flow manually, and to then pause it while displaying the progress dialog?

In the browser console, you can type window.open("chrome://global/content/resetProfileProgress.xhtml", "", "chrome,width=600,height=300");