1771149 - Select choice label is null at runtime despite having @NotNull annotation

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Alexandru Putanu [:aputanu]]

Issue created to bring awareness to the problem described here.

Based on https://github.com/mozilla-mobile/android-components/pull/12218#discussion_r880609397

Comment 1

[Chris Peterson [:cpeterson]]

        // On the GeckoView docs states that label is a @NonNull, but on run-time
        // we are getting null values

Is the bug that the label is null or that it should be annotated as @NonNull?

Comment 2

[Alexandru Putanu [:aputanu]]

The problem is that the label is received as null at runtime. It is currently annotated as @NotNull.

Comment 3

[Polly [:polly]]

Looks like the call site for this bug is on this line: https://searchfox.org/mozilla-central/rev/ab488b411ff15c2e11dbd4d6be0455bb64bc8fc1/mobile/android/android-components/components/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/ext/GeckoChoice.kt#15 and the Choice item is now nullable.

I think the task now is to remove the line @Suppress("USELESS_ELVIS").

Comment 4

[Faisal Masalha]

Attachment: Bug 1771149 Select choice label is null at runtime despite having @NotNull annotation r=ohall

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/560e7e076462
https://hg.mozilla.org/integration/autoland/rev/bfe9fc374f2c
Select choice label is null at runtime despite having @NotNull annotation r=ohall,geckoview-reviewers,android-reviewers

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/bfe9fc374f2c