1771271 - 102.0a1 Crash Report PLDHashTable::Search | mozilla::a11y::RemoteAccessibleBase<T>::RetrieveCachedBounds

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[qjfkcovb3]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Expected results:

Please refer to this Socorro:

https://crash-stats.mozilla.org/report/index/f41d3b5a-53f6-4f21-9620-d6e390220526#tab-details

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Search' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[James Teh [:Jamie]]

RetrieveCachedBounds should null check mCachedFields. That said, mCachedFields really shouldn't be null - it should contain bounds at the very least - unless we somehow tried to populate an Android node after it was shown but before the cache was sent. I wonder if that's a race condition we actually need to worry about? Eitan, thoughts?

Comment 3

[Eitan Isaacson [:eeejay]]

Since the cache push does not happen in line with remote tree creation, and since we dispatch the show event before the cache is populated, this is very possible.

We do check for mCachedFields in BoundsWithOffset, butonly for this, not for its ancestors. Need to fix that.

Comment 4

[Eitan Isaacson [:eeejay]]

It is a bit confounding that an ancestor would not have a cache bundle. perhaps it is the result of a move of some kind, or an embedded doc?

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1771271 - Check for mCachedFields for all remote accessibles in BoundsWithOffset. r?morgan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc8cef05c105
Check for mCachedFields for all remote accessibles in BoundsWithOffset. r=morgan

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cc8cef05c105

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Eitan, this fix seems to be effective, could you request an uplift to beta? Thanks!

Comment 11

[Eitan Isaacson [:eeejay]]

Comment on attachment 9278987 [details]
Bug 1771271 - Check for mCachedFields for all remote accessibles in BoundsWithOffset. r?morgan

Beta/Release Uplift Approval Request

• User impact if declined: Fixes crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a simple null check.
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9278987 [details]
Bug 1771271 - Check for mCachedFields for all remote accessibles in BoundsWithOffset. r?morgan

Approved for 102 beta 6, thanks.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/02b7b0ba17ee