1771273 - nss fails to build on gcc-13: cpputil/databuffer.h:20:20: error: 'uint8_t' does not name a type

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[slyich]

Attachment: nss-gcc-13-cstdint.patch

Steps to reproduce:

Attempted to build the system that includes firefox and nss with this week's gcc-13 snapshot. Recently #include <string> stopped including <cstdint> implicitly and that exposed a few problems.

Actual results:

Build failed as:

../../cpputil/databuffer.h:20:20: error: 'uint8_t' does not name a type
   20 |   DataBuffer(const uint8_t* d, size_t l) : data_(nullptr), len_(0) {
      |                    ^~~~~~~
../../cpputil/databuffer.h:14:1: note: 'uint8_t' is defined in header '<cstdint>'; did

you forget to '#include <cstdint>'?
13 | #include <iostream>
+++ |+#include <cstdint>
14 |

Comment 1

[slyich]

Attachment: Bug 1771273 - cpputil/databuffer.h: add missing <cstdint> include

Without the change build fails on this week's gcc-13 snapshot as:

../../cpputil/databuffer.h:20:20: error: 'uint8_t' does not name a type
   20 |   DataBuffer(const uint8_t* d, size_t l) : data_(nullptr), len_(0) {
      |                    ^~~~~~~
../../cpputil/databuffer.h:14:1: note: 'uint8_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   13 | #include <iostream>
  +++ |+#include <cstdint>
   14 |

Comment 2

[John Schanck [:jschanck]]

https://hg.mozilla.org/projects/nss/rev/21e7aaa1f7d94bca15d997e5b4c2329b32fad21a