1771282 - Dynamic timeline change doesn't remove from the pending play set.

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See diagnosis in bug 1730284 comment 22.

Comment 1

[Boris Chiou [:boris]]

Attachment: A simple testcase

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1771282 - Introduce ScrollTimelineAnimationTracker.

So we can handle the pending the case if this animation is still in the pending
animation tracker while changing timeline easily.

Besides, we have to make sure the start time and hold time are set
properly when setting the timeline, so we also implement the setup per
"if to finite timeline" part in the section of setting-the-timeline in
[web-animations-2],
https://drafts.csswg.org/web-animations-2/#setting-the-timeline.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1771282 - Part 1: Factor out the common part from PendingAnimationTracker.

We'd like to introduce anthor animation tracker for scroll-timeline, so
we factor out the common part first.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ace811f7315
Introduce ScrollTimelineAnimationTracker. r=hiro

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36741 for changes under testing/web-platform/tests

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bustages in dist/include/mozilla/RefPtr.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/30b19e195eef8d631e4c14256d735d2d2015374a

Push with failures

Failure log

INFO -  In file included from /builds/worker/workspace/obj-build/dist/include/nsISupportsUtils.h:17:
[task 2022-10-31T15:42:08.101Z] 15:42:08    ERROR -  /builds/worker/workspace/obj-build/dist/include/mozilla/RefPtr.h:49:37: error: member access into incomplete type 'mozilla::dom::Document'
[task 2022-10-31T15:42:08.102Z] 15:42:08     INFO -    static void AddRef(U* aPtr) { aPtr->AddRef(); }

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edac68e2456c
Introduce ScrollTimelineAnimationTracker. r=hiro

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/edac68e2456c

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Intermittent Failures Robot]

1 failures in 3914 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr102: 1

Platform and build breakdown:

• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1771282&startday=2023-01-23&endday=2023-01-29&tree=all

Comment 12

[Intermittent Failures Robot]

1 failures in 4004 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr102: 1

Platform and build breakdown:

• windows10-64-2004-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1771282&startday=2023-04-17&endday=2023-04-23&tree=all