1771353 - make sure browser/components/newtab workflows continue to work under Node 12 and Node 16

Status: RESOLVED FIXED

(Firefox :: Messaging System, task)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Mainly, we need to be sure that our node/npm-based workflows (i.e. the stuff where we build artifacts and do things with them) continue to work under Node 16 and Node 12, and that the generated artifacts work.

The ideal is that no dependencies would need to be upgraded. That may well be untrue, in which case, we would ideally land on dependency versions that work with both 12 and 16.

I don't know that it's necessary to actually use the binaries generated by the try server in bug 1762571, I would expect that just being sure you have Node 16 installed and at the front of your patch (and using node and npm rather than mach node, and mach npm would be sufficient.

The theory I've heard was about the Node 16 upgrade landing this coming Monday the 30th of May. Whether that will actually come to pass, I'm not sure.

Comment 1

[Emily McMinn :emcminn]

After applying the patch from https://bugzilla.mozilla.org/show_bug.cgi?id=1762571 and running bootstrap (artifact build), I can confirm I have node v16.0.0 and npm 7.10.0 locally, and so far the following are all green:

-./mach clobber

• ./mach build
• ./mach run
• npm run bundle --prefix browser/components/newtab
  -npm run test --prefix browser/components/newtab (This also runs ./mach lint and eslint)
  -./mach test browser/components/newtab both with and without --headless

I did get a few failures with ./mach test toolkit/components/nimbus but having run them a few more times I think they are intermittents from nimbus and nothing to do with the node/npm versions.