1771408 - Hit MOZ_CRASH(assertion failed: self.active_surfaces.is_empty()) at gfx/wr/webrender/src/render_task_graph.rs:591

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Found while fuzzing m-c 20220525-41271d27d65a (--enable-debug --enable-fuzzing)

To reproduce via Grizzly Replay:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch -d --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html --xvfb

Hit MOZ_CRASH(assertion failed: self.active_surfaces.is_empty()) at gfx/wr/webrender/src/render_task_graph.rs:591

#0 0x7f535387ecf5 in MOZ_Crash /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:261:3
#1 0x7f535387ecf5 in RustMozCrash /builds/worker/checkouts/gecko/mozglue/static/rust/wrappers.cpp:18:3
#2 0x7f535387eb54 in mozglue_static::panic_hook::ha203d40143d12c16 /builds/worker/checkouts/gecko/mozglue/static/rust/lib.rs:91:9
#3 0x7f535387e6db in core::ops::function::Fn::call::h2e8e93985c21adf5 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:70:5
#4 0x7f535464ff03 in std::panicking::rust_panic_with_hook::h3b7380e99b825b63 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:702:17
#5 0x7f535464fb78 in std::panicking::begin_panic_handler::_$u7b$$u7b$closure$u7d$$u7d$::h8e849d0710154ce0 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:586:13
#6 0x7f535464bb03 in std::sys_common::backtrace::__rust_end_short_backtrace::hedcdaddbd4c46cc5 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/sys_common/backtrace.rs:138:18
#7 0x7f535464f8c8 in rust_begin_unwind /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:584:5
#8 0x7f5349f13892 in core::panicking::panic_fmt::he1bbc7336d49a357 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panicking.rs:143:14
#9 0x7f5349f1375c in core::panicking::panic::h4241c5ccea17faca /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panicking.rs:48:5
#10 0x7f535326a508 in webrender::render_task_graph::RenderTaskGraphBuilder::end_frame::h93fdb30eb9c36f0f /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_task_graph.rs
#11 0x7f53531bb483 in webrender::frame_builder::FrameBuilder::build::hf64b01a8e46e2b5c /builds/worker/checkouts/gecko/gfx/wr/webrender/src/frame_builder.rs:553:28
#12 0x7f53532408e6 in webrender::render_backend::Document::build_frame::h7387771b02a6788a /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:498:25
#13 0x7f5353256bdf in webrender::render_backend::RenderBackend::update_document::h3942776e450b1ad4 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:1389:41
#14 0x7f535324bafe in webrender::render_backend::RenderBackend::prepare_transactions::h765c0dc086b40391 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:1239:28
#15 0x7f535324bafe in webrender::render_backend::RenderBackend::process_api_msg::hf9a46b35deb4bab0 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:1092:17
#16 0x7f535328fedc in webrender::render_backend::RenderBackend::run::he8c5c016d6d3473f /builds/worker/checkouts/gecko/gfx/wr/webrender/src/render_backend.rs:756:21
#17 0x7f535328fedc in webrender::renderer::Renderer::new::_$u7b$$u7b$closure$u7d$$u7d$::hdd279e1252bdb24a /builds/worker/checkouts/gecko/gfx/wr/webrender/src/renderer/mod.rs:1337:13
#18 0x7f535328fedc in std::sys_common::backtrace::__rust_begin_short_backtrace::h3fc15b0fd538079c /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/sys_common/backtrace.rs:122:18
#19 0x7f5353011cfe in std::thread::Builder::spawn_unchecked_::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::hc5e4e8c5207be9fc /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/thread/mod.rs:498:17
#20 0x7f5353011cfe in _$LT$core..panic..unwind_safe..AssertUnwindSafe$LT$F$GT$$u20$as$u20$core..ops..function..FnOnce$LT$$LP$$RP$$GT$$GT$::call_once::hb6fe521d14f0d523 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/panic/unwind_safe.rs:271:9
#21 0x7f5353011cfe in std::panicking::try::do_call::hd172353aff5e6782 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:492:40
#22 0x7f5353011cfe in std::panicking::try::hdd5867bd309629dd /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panicking.rs:456:19
#23 0x7f5353011cfe in std::panic::catch_unwind::had2d17623c35f7da /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/panic.rs:137:14
#24 0x7f5353011cfe in std::thread::Builder::spawn_unchecked_::_$u7b$$u7b$closure$u7d$$u7d$::h667b5281025cc4ad /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/thread/mod.rs:497:30
#25 0x7f5353011cfe in core::ops::function::FnOnce::call_once$u7b$$u7b$vtable.shim$u7d$$u7d$::hd6637db685d6d525 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/core/src/ops/function.rs:227:5
#26 0x7f535465bb22 in _$LT$alloc..boxed..Box$LT$F$C$A$GT$$u20$as$u20$core..ops..function..FnOnce$LT$Args$GT$$GT$::call_once::hf70ac038171e3e1a /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/alloc/src/boxed.rs:1853:9
#27 0x7f535465bb22 in _$LT$alloc..boxed..Box$LT$F$C$A$GT$$u20$as$u20$core..ops..function..FnOnce$LT$Args$GT$$GT$::call_once::he6690128792365ad /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/alloc/src/boxed.rs:1853:9
#28 0x7f535465bb22 in std::sys::unix::thread::Thread::new::thread_start::ha07928d93d5a5ec9 /rustc/7737e0b5c4103216d6fd8cf941b7ab9bdbaace7c/library/std/src/sys/unix/thread.rs:108:17
#29 0x7f5360d70608 in start_thread /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:477:8
#30 0x7f5360937132 in __clone /build/glibc-SzIz7B/glibc-2.31/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Comment 1

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220526213638-f392452506ec.
The bug appears to have been introduced in the following build range:

Start: e758f99cfd50274790c68853e7e43601dfc5cc03 (20220525034254)
End: 07d584cd2e3ba0f83ff2982d73f46218703ed3bc (20220525053027)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e758f99cfd50274790c68853e7e43601dfc5cc03&tochange=07d584cd2e3ba0f83ff2982d73f46218703ed3bc

Comment 2

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/I1rYJE4UN5J4_C_CNYBGrg/index.html

Comment 3

[Mayank Bansal]

Regression range shows bug 1770045 or bug 1769963
ni: gw.

Comment 4

[Glenn Watson [:gw]]

I was unable to reproduce this locally, but it's likely to be fixed by https://phabricator.services.mozilla.com/D147482 - let's see if the fuzzer can still repro after that lands.

Comment 5

[Mayank Bansal]

The crash signature has changed to https://crash-stats.mozilla.org/report/index/f19702fb-2055-4b3c-a5ee-0bc210220528#tab-bugzilla
I also see "tab getting blank" behaviour similar to bug 1771573
Open the testcase on 1.5 DPI, and pinch-zoom

Comment 6

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Testcase crashes using the initial build (mozilla-central 20220525150600-41271d27d65a) but not with tip (mozilla-central 20220527213513-21fcc945a41d.)
The bug appears to have been fixed in the following build range:

Start: b635369043bdbc4e9085c4403ca11c7cacd108b4 (20220527035447)
End: e0d03b74ed8352d3e52f44f48641bef88272e6e0 (20220527073811)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b635369043bdbc4e9085c4403ca11c7cacd108b4&tochange=e0d03b74ed8352d3e52f44f48641bef88272e6e0
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 7

[Mayank Bansal]

https://crash-stats.mozilla.org/report/index/5385f9bf-1db8-46c9-9495-96bd80220529#tab-bugzilla with latest nightly

Comment 8

[Tyson Smith [:tsmith]]

Attachment: testcase.html

Updated test case that reproduces with m-c 20220529-ac2e51f9332e.

I will also get a Pernosco session.

Comment 9

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/JoAmJ2j_Lm9SJseKfPK8JQ/index.html

Comment 10

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220529090310-ac2e51f9332e.
The bug appears to have been introduced in the following build range:

Start: 1e98fd258975d2e4bc9b7d9ed20d4d0a91f7cf9f (20220518031437)
End: 79f4180c783b1e72fccb1e49fb8db086ea12ecca (20220518033138)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1e98fd258975d2e4bc9b7d9ed20d4d0a91f7cf9f&tochange=79f4180c783b1e72fccb1e49fb8db086ea12ecca

Comment 11

[Mayank Bansal]

fixed by bug 1771556

Comment 12

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as fixed on rev mozilla-central 20220601213138-08038e535f58.
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Is bug 1771556 something we should consider uplifting to Beta?

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Nevermind, I see the request is already there!