1771476 - Do not export lazy getter "PREFS_GUID" from services/sync/modules/engines/prefs.js

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/b462b11e71b500e084f51e61fbd9e19ea0122c78/services/sync/modules/engines/prefs.js#5,30-32

var EXPORTED_SYMBOLS = ["PrefsEngine", "PrefRec", "PREFS_GUID"];
...
XPCOMUtils.defineLazyGetter(this, "PREFS_GUID", () =>
  CommonUtils.encodeBase64URL(Services.appinfo.ID)
);

This exports lazy getter "PREFS_GUID" defined on the per-JSM global this.
This is not possible with ESM, and this needs to be rewritten not to rely on global this

This is exported only for testing, so exporting testing-only function that returns PREFS_GUID should work

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1771476 - Do not export lazy getter "PREFS_GUID" from services/sync/modules/engines/prefs.js. r?markh!

PREFS_GUID is a lazy getter, and it cannot be exported once ESM-ified.

Depends on D147597

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e974f500a0b
Do not export lazy getter "PREFS_GUID" from services/sync/modules/engines/prefs.js. r=markh

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6e974f500a0b