177153 - Clean up code for toggling items

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

There are several methods like:

  toggleFoo(aExplicit, aValue)
  {
    var val = aExplicit ? aValue : !this.mFoo;
    // do stuff with the value
  }

this bug is to clean those up since the aExplicit parameter is quite useless. 
For one, you can tell in JS if there is a parameter or not just by checking the
typeof it.  Secondly, these should probably be replaced by a toggleFoo() and
setFoo(aValue), depending on what the caller wants to do.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 104395 [details] [diff] [review]
patch

> +  setBrowser: function(aValue, aShouldOpen)

aShouldOpen would make more sense as aToggleSplitter, no?

+  toggleSearch: function(aShouldOpen)

Same.  With those changes, sr=bzbarsky

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Landed