Support scores in the Firefox Suggest remote settings source
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [snt-triaged])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Right now remote settings Suggest suggestions get a hardcoded constant score, and the user's search string will only ever match one suggestion. After bug 1771427 lands, search strings will be able to match multiple suggestions, but since all RS suggestions have the same score, the only way the client can prefer one matching RS suggestion over another is by making sure the preferred suggestion comes before the other one in the dataset. In other words, the client will prefer suggestions in FIFO order. That behavior is fragile and opaque, and fortunately we can improve the situation by using the existing scoring functionality and giving preferred suggestions a higher score. We just need to support RS scores in the client.
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
This is a pretty simple change. RS suggestions can now have a score
defined.
Sorting by score and picking the suggestion with the largest score is already
handled by the provider.
This modifies the test added in D147483 so that it sets some scores on
suggestions that cause the ordering to change.
Depends on D147483
Assignee | ||
Comment 2•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38f5dda78cdb Support scores in the Firefox Suggest remote settings source. r=nanj
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Comment on attachment 9278553 [details]
Bug 1771537 - Support scores in the Firefox Suggest remote settings source.
Beta/Release Uplift Approval Request
- User impact if declined: This is necessary sooner rather than later for the Firefox Suggest offline expansion feature/experiment.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1771427 must be uplifted first
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a minor architectural change for Firefox Suggest with no visible user-facing consequences.
- String changes made/needed:
- Is Android affected?: No
Comment 5•2 years ago
|
||
bugherder |
Comment 6•2 years ago
|
||
Comment on attachment 9278553 [details]
Bug 1771537 - Support scores in the Firefox Suggest remote settings source.
Approved for 102 beta 3, thanks.
Comment 7•2 years ago
|
||
bugherder uplift |
Description
•