177160 - Cannot remember empty URL field value in bookmarkable templates

Status: RESOLVED DUPLICATE of bug 181486

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

Steps to reproduce:

1. Go to an enter bug form.
2. Remove the 'http://' value from the URL field.
3. Click the 'Remember values as bookmarkable template' button
4. Bookmark the link provided.
5. Visit the bookmark.

Actual results:
* The URL field contains 'http://'

Expected results:
* The URL field should be blank.

Comment 1

[Dave Miller [:justdave]]

I'm pretty sure that's intentional.

On the other hand, I suppose if you look for "defined $::FORM{bug_loc}" instead
of "if !$::FORM{bug_loc}" you could probably tell the difference...

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

If it's intentional (which I agree with you after seeing the code) then it is
IMO a bug.  "" is a legal value for a form field.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

--- webtools/bugzilla/enter_bug.cgi     1 Oct 2002 22:41:07 -0000       1.75
+++ webtools/bugzilla/enter_bug.cgi     28 Oct 2002 20:41:14 -0000
@@ -106,5 +106,7 @@
 sub formvalue {
     my ($name, $default) = (@_);
-    return $::FORM{$name} || $default || "";
+    return defined $::FORM{$name}
+           ? $::FORM{$name}
+           : ($default || "");
 }

Comment 4

[Shane H. W. Travis]

Although bug 181486 came later, it is more comprehensive on what things aren't 
carried over as a bookmark, so I'm duping this one to that one.



*** This bug has been marked as a duplicate of 181486 ***