1771650 - bdi tag closed twice in toolkit/content/widgets/videocontrols.js

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Nick]

Steps to reproduce:

Do not know if this has any effect, but noticed it reading trough the source code.

The bdi tag has a, from the looks of it, a stray closing bracket.

https://hg.mozilla.org/mozilla-central/file/e881fd99de24fa48159390544dac07f373931d1c/toolkit/content/widgets/videocontrols.js#l2847

Actual results:

<bdi class="statusLabel" id="errorGeneric"> data-l10n-id="videocontrols-error-generic"></bdi>

Expected results:

<bdi class="statusLabel" id="errorGeneric" data-l10n-id="videocontrols-error-generic"></bdi>

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Themes' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Tooru Fujisawa [:arai]]

Thank you for reporting!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:niklas, since you are the author of the regressor, bug 1654054, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Mathew Hodson]

Attachment: Bug 1771650 - Fix `<bdi>` tag in videocontrols.js. r?mconley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa5e5a29437
Fix `<bdi>` tag in videocontrols.js. r=Gijs

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/4fa5e5a29437

Comment 7

[:Gijs (he/him)]

Comment on attachment 9278661 [details]
Bug 1771650 - Fix <bdi> tag in videocontrols.js. r?mconley

Beta/Release Uplift Approval Request

• User impact if declined: Potential for brokenness in video control error handling
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a trivial patch correcting a markup mistake
• String changes made/needed: Nope
• Is Android affected?: Yes

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9278661 [details]
Bug 1771650 - Fix <bdi> tag in videocontrols.js. r?mconley

Low risk, approved for 102 beta 2, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b49285857431

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this bug likely to manifest in a user-facing way?

Comment 11

[Mathew Hodson]

I don't think users are likely to see this bug. This code is used if a <video> element fails with an error that isn't handled by any of the listed cases. I don't know how to reproduce it.

https://searchfox.org/mozilla-central/rev/1739f1301d658c9bff544a0a095ab11fca2e549d/toolkit/content/widgets/videocontrols.js#1104-1140
https://searchfox.org/mozilla-central/rev/1739f1301d658c9bff544a0a095ab11fca2e549d/toolkit/locales/en-US/toolkit/global/videocontrols.ftl#46-50

videocontrols-error-aborted = Video loading stopped.
videocontrols-error-network = Video playback aborted due to a network error.
videocontrols-error-decode = Video can’t be played because the file is corrupt.
videocontrols-error-src-not-supported = Video format or MIME type is not supported.
videocontrols-error-no-source = No video with supported format and MIME type found.