1771659 - Perma TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js when Gecko 102 merges to Beta on 2022-05-30

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Cosmin Sabou [:CosminS]]

This is a bug that started with the beta-sim from the 19th May here but was hidden under Bug 1767702 that fails on trunk only on linux1804-64-qr opt/debug + shippable and windows opt/debug + shippable, ccov.
This one instead is perma failing on all platforms it runs in beta-sims.

Central as beta simulation

How to run these simulations

Failure log:

[task 2022-05-19T14:05:13.495Z] 14:05:13     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js | Connected - 
[task 2022-05-19T14:05:13.495Z] 14:05:13     INFO - Buffered messages logged at 14:02:12
[task 2022-05-19T14:05:13.496Z] 14:05:13     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 4
[task 2022-05-19T14:05:13.496Z] 14:05:13     INFO - Buffered messages logged at 14:02:57
[task 2022-05-19T14:05:13.496Z] 14:05:13     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 3
[task 2022-05-19T14:05:13.496Z] 14:05:13     INFO - Buffered messages logged at 14:03:43
[task 2022-05-19T14:05:13.497Z] 14:05:13     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 2
[task 2022-05-19T14:05:13.497Z] 14:05:13     INFO - Buffered messages logged at 14:04:28
[task 2022-05-19T14:05:13.498Z] 14:05:13     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 1
[task 2022-05-19T14:05:13.498Z] 14:05:13     INFO - Buffered messages logged at 14:04:31
[task 2022-05-19T14:05:13.499Z] 14:05:13     INFO - Console message: [JavaScript Error: "Invalid ETag value "undefined"" {file: "resource://services-settings/SyncHistory.jsm" line: 50}]
[task 2022-05-19T14:05:13.499Z] 14:05:13     INFO - store@resource://services-settings/SyncHistory.jsm:50:13
[task 2022-05-19T14:05:13.499Z] 14:05:13     INFO - async*remoteSettingsFunction/remoteSettings.pollChanges@resource://services-settings/remote-settings.js:429:8
[task 2022-05-19T14:05:13.499Z] 14:05:13     INFO - async*notify@resource://services-settings/RemoteSettingsComponents.jsm:22:20
[task 2022-05-19T14:05:13.499Z] 14:05:13     INFO - TM_notify/<@resource://gre/modules/UpdateTimerManager.jsm:223:50
[task 2022-05-19T14:05:13.499Z] 14:05:13     INFO - TM_notify@resource://gre/modules/UpdateTimerManager.jsm:294:7
[task 2022-05-19T14:05:13.499Z] 14:05:13     INFO - 
[task 2022-05-19T14:05:13.500Z] 14:05:13     INFO - Buffered messages finished
[task 2022-05-19T14:05:13.500Z] 14:05:13     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js | Test timed out - 
[task 2022-05-19T14:05:13.501Z] 14:05:13     INFO - Removing tab.
[task 2022-05-19T14:05:13.501Z] 14:05:13     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.502Z] 14:05:13     INFO - Got event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.502Z] 14:05:13     INFO - Tab removed and finished closing
[task 2022-05-19T14:05:13.502Z] 14:05:13     INFO - Removing tab.
[task 2022-05-19T14:05:13.503Z] 14:05:13     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.503Z] 14:05:13     INFO - Got event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.504Z] 14:05:13     INFO - Tab removed and finished closing
[task 2022-05-19T14:05:13.504Z] 14:05:13     INFO - Removing tab.
[task 2022-05-19T14:05:13.505Z] 14:05:13     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.505Z] 14:05:13     INFO - Got event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.505Z] 14:05:13     INFO - Tab removed and finished closing
[task 2022-05-19T14:05:13.506Z] 14:05:13     INFO - Removing tab.
[task 2022-05-19T14:05:13.506Z] 14:05:13     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.507Z] 14:05:13     INFO - Got event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.507Z] 14:05:13     INFO - Tab removed and finished closing
[task 2022-05-19T14:05:13.507Z] 14:05:13     INFO - Removing tab.
[task 2022-05-19T14:05:13.508Z] 14:05:13     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.508Z] 14:05:13     INFO - Got event: 'TabClose' on [object XULElement].
[task 2022-05-19T14:05:13.508Z] 14:05:13     INFO - Tab removed and finished closing
[task 2022-05-19T14:05:13.509Z] 14:05:13     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js | The main process DevToolsServer has no pending connection when the test ends -

Comment 1

[Cosmin Sabou [:CosminS]]

The test has now been disabled on windows on trunk for frequent failures in https://hg.mozilla.org/mozilla-central/rev/d9b98e7235eb, on beta is failing on every platform it runs.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

I took a look if there was a WebExtensions-related about:config pref that was set to a different default value on beta and could have triggered this perma failure, but it seems that currently the test task testSourceTreeNamesForWebExtensions has to explicitly set the "devtools.browsertoolbox.fission" pref to true to pass consistently on the non-nightly channels, because that is currently set to true by default only on Nightly and enabling the "Multiprocess Browser Toolbox" mode will be necessary for the test to then expect the system addons extensions to be listed in the BrowserToolbox jsdebugger panel:

diff --git a/devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js b/devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js
--- a/devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js
+++ b/devtools/client/debugger/test/mochitest/browser_dbg-features-source-tree.js
@@ -432,6 +432,7 @@ add_task(async function testSourceTreeWi
 // browser toolbox.
 add_task(async function testSourceTreeNamesForWebExtensions() {
   await pushPref("devtools.chrome.enabled", true);
+  await pushPref("devtools.browsertoolbox.fission", true);
   const extension = await installAndStartContentScriptExtension();
 
   const dbg = await initDebugger("doc-content-script-sources.html");

The one line change above was enough to make the test to pass consistently locally on a Firefox 102 Beta artifact built.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1766237

Comment 4

[Intermittent Failures Robot]

1 failures in 2917 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux1804-64-devedition-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1771659&startday=2022-05-30&endday=2022-06-05&tree=all

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1771659 - [devtools] Fix perma failure in BETA r=ochameau

The multiprocess browser toolbox is on by default in BETA, so we
need to switch it on explicitly for the addon extensions to be listed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e440a0831a58
[devtools] Fix perma failure in BETA r=ochameau

Comment 7

[bszekely]

Patch does not fix the perma failure, we came across other instances of this fail in today's beta simulation.

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/e440a0831a58

Comment 9

[Julian Descottes [:jdescottes]]

(In reply to bszekely from comment #7)

Patch does not fix the perma failure, we came across other instances of this fail in today's beta simulation.

The test is still quite intermittent on windows: https://bugzilla.mozilla.org/show_bug.cgi?id=1767702
And the try push linked here does not show a permafailure for this test, eg https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=647cbaefff41b9b238cd274614f45302cbf05d2b&searchStr=dt&selectedTaskRun=AHYvqANhQK2WwXN_7S3Z3A.0 failed because of another test (browser_console_enable_network_monitoring.js) which is another perma, being fixed right now.

Comment 10

[Sandor Molnar[:smolnar]]

Fixed in todays beta-sim

Comment 11

[Cosmin Sabou [:CosminS]]

The test is skipped on beta https://hg.mozilla.org/releases/mozilla-beta/rev/f9b710930a6c3680aa994051e6a6ec6d9a380aa6
bomsy if you want to fix this also on beta you should request an uplift and re-enable the test.

Comment 12

[Hubert Boma Manilla (:bomsy)]

It still seem to be some intermittent around this from Bug 1767702, and not an urgent to enable the test. So i'll not uplift.
Thanks

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bomsy, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.