1771705 - Consider removing ping name from test_get_num_recorded_errors

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Jan-Erik Rediger [:janerik]]

We don't actually need that: errors always also go to the metrics ping on top of whatever ping this metric normally goes in. So we could be safe just removing the ping name parameter and always assuming metrics.

Comment 1

[Chris H-C :chutten]

theoretically if a "metrics" ping is sent and the custom ping hasn't, then there would be a measurable difference, but as we haven't exposed this to consumers in the past, maybe it doesn't matter...

...buutttttt, if we combine test_get_num_recorded_errors with test_get_value (which does take a ping_name param) like FOG does, then maybe this all goes away.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/2088

Comment 3

[Jan-Erik Rediger [:janerik]]

badboy merged PR #2088: "Bug 1771705 - Remove ping name from test_get_num_recorded_errors" in 4001b78.