177173 - export more string fanout.

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Doug Turner (:dougt)]

Comment 1

[Doug Turner (:dougt)]

Attachment: export -> sdk export

this is all of the fanout needed to use nsEmbedString from the SDK without
having to include dist/include/

Comment 2

[Alec Flett]

Comment on attachment 104406 [details] [diff] [review]
export -> sdk export

sr=alecf

yikes, thats a lot of headers. Oh well.

Comment 3

[jag (Peter Annema)]

Comment on attachment 104406 [details] [diff] [review]
export -> sdk export

dist/include/string I suspect you meant.

You could get rid of the nsDependentConcatenation include with a minor tweak to
http://lxr.mozilla.org/seamonkey/source/string/public/nsAString.h#813

I'd rather not put that in the SDK until I've found a way to fix the bug (I
seem to recall being able to do it without an API change, at a cost, which
might (or might not) negate the win from doing a dependent concatenation.)

Comment 4

[jag (Peter Annema)]

Oh, and I just marked alecf's sr, that wasn't me sr'ing and forgetting to say so
in the comment ;-)

Comment 5

[Doug Turner (:dougt)]

Attachment: with jag's suggestion

Comment 6

[jag (Peter Annema)]

Comment on attachment 104425 [details] [diff] [review]
with jag's suggestion

r=jag, carrying over sr=alecf

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 104425 [details] [diff] [review]
with jag's suggestion

a=roc+moz for trunk

Comment 8

[Doug Turner (:dougt)]

Checking in Makefile.in;
/cvsroot/mozilla/string/public/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done
Checking in nsAString.h;
/cvsroot/mozilla/string/public/nsAString.h,v  <--  nsAString.h
new revision: 1.21; previous revision: 1.20
done