1771734 - Remove unused DTD strings

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Eemeli Aro [:eemeli]]

Using the script that's linked in 1580981, I've found a bunch of unused DTD strings:

mobile/android/branding/beta/locales/en-US/brand.dtd
mobile/android/branding/nightly/locales/en-US/brand.dtd
mobile/android/branding/unofficial/locales/en-US/brand.dtd
mobile/android/branding/official/locales/en-US/brand.dtd
  &brandFullName;
  &brandPocket;

mobile/locales/en-US/overrides/netError.dtd
  &connectionFailure.longDesc2;
  &dnsNotFound.longDesc4;
  &malformedURI.longDesc2;
  &netInterrupt.longDesc2;
  &netReset.longDesc2;
  &netTimeout.longDesc2;
  &proxyResolveFailure.longDesc3;
  &sslv3Used.title;
  &sslv3Used.longDesc;
  &weakCryptoUsed.title;
  &weakCryptoUsed.longDesc;

toolkit/locales/en-US/chrome/global/notification.dtd
  &checkForUpdates;

At least the mobile netError.dtd strings appear to have been left unused by 1589182.

Comment 1

[Eemeli Aro [:eemeli]]

Attachment: Bug 1771734 - Drop unused DTD strings. r=flod

This follows in the same vein as bug 1771133,
and cleans up some strings that were orphaned by bug 1589182.

Comment 2

[Francesco Lodolo [:flod]]

Reminder to land this once you get L3 access.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:eemeli, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/311f4827c961
Drop unused DTD strings. r=flod,geckoview-reviewers,m_kato

Comment 5

[Eemeli Aro [:eemeli]]

Finally got L3 rights so was able to land this today. Delay was due to travel (conference, team work week) over the past two weeks.

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/311f4827c961