1771794 - Structured `metrics` pings missing `metrics.timespan.fog.initialization.time_unit` and `metrics.timespan.fog.initialization.value` columns

Status: RESOLVED FIXED

(Data Platform and Tools :: General, defect, P1)

Description

[Eduardo Filho [:efilho]]

Attachment: health check dashboard showing the missing columns

Comment 1

[Sean Rose [:srose]]

firefox_desktop_background_update.metrics_v1 is still missing metrics.timespan.fog.initialization.time_unit and metrics.timespan.fog.initialization.value.

:chutten is this something we should care about/fix?

Comment 2

[Chris H-C :chutten|RustWeek (Back May 25)]

Ideally, yes. It has a problem that is being fixed in bug 1797619, but once fixed I hope to add it to the FOG Monitoring dashboard so it can be monitored for performance regression.

...uh-oh. Okay. I thought background_update depended on gecko like how firefox_desktop does... but it doesn't. I guess I missed this when I reorganized things in bug 1724303.

Hrm. For now this doesn't matter much as most/all of the pings those metrics are sent in aren't even sent by the app (aside from the occasional "metrics" ping that leaks. Still not sure how. Old builds?), but that will change with bug 1809460 (which embeds my previous assumption that it already depended on gecko).

Okay, okay. Action time.

1. :srose, the systems are operating as they've been directed. Unfortunately I've not done enough to direct them as I intended. Sorry about that.
2. I'll file a patch on probe-scraper referencing this bug that will add a gecko dep to firefox_desktop_background_update. This should add the columns and address the health check, if I don't miss my guess.

Comment 3

[Chris H-C :chutten|RustWeek (Back May 25)]

Attachment: pr 540: bug 1771794 - Firefox Desktop Background Update also reports gecko metrics

Comment 4

[Chris H-C :chutten|RustWeek (Back May 25)]

chutten merged PR #540: "bug 1771794 - Firefox Desktop Background Update also reports gecko metrics" in bb4cbc0.

That should take care of it.