1771888 - Reduce cloning of submetrics for labeled metrics

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Jan-Erik Rediger [:janerik]]

We're cloning the submetric on each access now inside FOG.
We should restructure that to avoid cloning and re-use objects where possible.
glean-core alreay gives us an Arc, which we might be able to pass on.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1771888 - Put labeled metrics into an arc to avoid cloning. r?chutten!

This means we need that Arc in boolean, counter & string,
but we avoid cloning the internal metric. Glean already made that
optimization lately.

Note 1: The actual metric types use an Arc internally in glean-core,
so we're nesting Arcs here. I don't think that's problematic though.

Note 2: No measurements have been done whether this really changes much.
Also we probably do not have that many labeled metrics yet for it to
make a measurable difference to begin with.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ebed9d7c52d
Put labeled metrics into an arc to avoid cloning. r=chutten

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0ebed9d7c52d