Closed Bug 1771942 Opened 2 years ago Closed 1 year ago

Update atom.js for revision a6b161a159c3d581b130f03a2e6e35f577f38dec (2022-10)

Categories

(Remote Protocol :: Agent, task, P5)

Product:
Remote Protocol
Component:
Agent
Type:
task

Tracking

(firefox107 fixed)

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: whimboo, Assigned: david.burns)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1771942: Update the Selenium Atoms used by Marionette.
48 bytes, text/x-phabricator-request
Details | Review

The WebDriver classic specification has the following information about the usage of helpers as defined in the Selenium code base:

Selenium
    The following functions are defined within the Selenium project, at revision 1721e627e3b5ab90a06e82df1b088a33a8d11c20.

        bot.dom.getVisibleText
        bot.dom.isShown

It's not clear to me if we actually make use of this revision given that some changes in 1721e627e3b5ab90a06e82df1b088a33a8d11c20 especially around shadow DOM aren't present in our vendored in copy. The last update for the atoms have been done via bug 1375660 and as it looks like I was using facd199c31c9d81316a1db3bbb0c10603799bb8b which is from September 2017 which is later than the referenced revision in the spec which dates to January 17 2017. But since then no more update has been done.

Also we make use of the following methods right now:

As it looks like we should not use atom.isElementEnabled anymore and instead rely on the steps as purely defined in the WebDriver specification.

Not a priority and as long nothing is broken we will defer an update.

Priority: -- → P5
Assignee: nobody → david.burns

The related PR for the WebDriver classic spec update can be found here:
https://github.com/w3c/webdriver/pull/1673

URL: https://github.com/w3c/webdriver/pull...

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: david.burns → nobody

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Assignee: nobody → david.burns
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18bafbcb268e
Update the Selenium Atoms used by Marionette. r=webdriver-reviewers,jgraham
Summary: Revise usage of atom.js and update to WebDriver specs referenced Selenium revision → Update atom.js for revision a6b161a159c3d581b130f03a2e6e35f577f38dec (2022-10)

https://hg.mozilla.org/mozilla-central/rev/18bafbcb268e

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Regressions: 1824664
You need to log in before you can comment on or make changes to this bug.