Closed
Bug 1772022
Opened 2 years ago
Closed 2 years ago
Make `EditorBase::DeleteNodeWithTransaction` return `NS_ERROR_EDITOR_DESTROYED`
Categories
(Core :: DOM: Editor, task, P2)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•2 years ago
|
||
Its callers check EditorBase::Destroyed() with at least adding 4 lines, and
some callers do not check this important state. So, we should make it check
Destroyed() at last and omit the additional error check in the caller sites.
Note that it's a virtual method, but HTMLEditor checks whether it's a
removable node or not. So, we should can merge it into EditorBase. This
patch does it too.
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/03bca2a3465c Make `EditorBase::DeleteNodeWithTransaction()` return `NS_ERROR_EDITOR_DESTROYED` if so r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•